Update ipfw regression tests after ipfw updated some opcode size
ClosedPublic
Actions

Authored by olivier on Thu, Oct 2, 11:25 PM.

Details

Reviewers

ae
glebius

Group Reviewers

network

Commits

rG01d5a6f30ce8: tests/ipfw: Update regression tests to match new 32-bit size rule numbers

Summary

The commit 4a77657cbc01 "ipfw: migrate ipfw to 32-bit size rule numbers" increase the size of some opcode but didn’t update the regression tests.

Test Plan

Before:

olivier@bigone:/usr/tests $ sudo kyua test sbin/ipfw/test_add_rule.py
36/46 passed (0 broken, 9 failed, 1 skipped)

After:

olivier@bigone:/usr/tests $ sudo kyua test sbin/ipfw/test_add_rule.py
45/46 passed (0 broken, 0 failed, 1 skipped)

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

olivier created this revision.Thu, Oct 2, 11:25 PM

Herald added subscribers: vegeta_tuxpowered.net, donner, melifaro. · View Herald TranscriptThu, Oct 2, 11:25 PM

olivier requested review of this revision.Thu, Oct 2, 11:25 PM

ae accepted this revision as: ae.Fri, Oct 3, 7:47 AM

This revision is now accepted and ready to land.Fri, Oct 3, 7:47 AM

Closed by commit rG01d5a6f30ce8: tests/ipfw: Update regression tests to match new 32-bit size rule numbers (authored by olivier). · Explain WhyFri, Oct 3, 11:09 AM

This revision was automatically updated to reflect the committed changes.

olivier added a commit: rG01d5a6f30ce8: tests/ipfw: Update regression tests to match new 32-bit size rule numbers.

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 3, 11:09 AM

Revision Contents
Changeset List

Path

Size

		atf_python/	sys/	netpfil/	ipfw/
	tests/	atf_python/	sys/	netpfil/	ipfw/

insns.py

19 lines

		ipfw/	tests/
	sbin/	ipfw/	tests/

test_add_rule.py

25 lines

Diff 163395

View Options

atf_python/sys/netpfil/ipfw/insns.py