Update ipfw regression tests after ipfw updated some opcode size
ClosedPublic
Actions

Authored by olivier on Oct 2 2025, 11:25 PM.

Details

Reviewers

ae
glebius

Group Reviewers

network

Commits

rG36098bbfbcaa: tests/ipfw: Update regression tests to match new 32-bit size rule numbers
rG01d5a6f30ce8: tests/ipfw: Update regression tests to match new 32-bit size rule numbers

Summary

The commit 4a77657cbc01 "ipfw: migrate ipfw to 32-bit size rule numbers" increase the size of some opcode but didn’t update the regression tests.

Test Plan

Before:

olivier@bigone:/usr/tests $ sudo kyua test sbin/ipfw/test_add_rule.py
36/46 passed (0 broken, 9 failed, 1 skipped)

After:

olivier@bigone:/usr/tests $ sudo kyua test sbin/ipfw/test_add_rule.py
45/46 passed (0 broken, 0 failed, 1 skipped)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olivier created this revision.Oct 2 2025, 11:25 PM

Herald added subscribers: vegeta_tuxpowered.net, donner, melifaro. · View Herald TranscriptOct 2 2025, 11:25 PM

olivier requested review of this revision.Oct 2 2025, 11:25 PM

ae accepted this revision as: ae.Oct 3 2025, 7:47 AM

This revision is now accepted and ready to land.Oct 3 2025, 7:47 AM

Closed by commit rG01d5a6f30ce8: tests/ipfw: Update regression tests to match new 32-bit size rule numbers (authored by olivier). · Explain WhyOct 3 2025, 11:09 AM

This revision was automatically updated to reflect the committed changes.

olivier added a commit: rG01d5a6f30ce8: tests/ipfw: Update regression tests to match new 32-bit size rule numbers.

Herald added a subscriber: imp. · View Herald TranscriptOct 3 2025, 11:09 AM

olivier added a commit: rG36098bbfbcaa: tests/ipfw: Update regression tests to match new 32-bit size rule numbers.Nov 3 2025, 6:24 AM

Revision Contents
Changeset List

Path

Size

sbin/

ipfw/

tests/

test_add_rule.py

25 lines

tests/

atf_python/

sys/

netpfil/

ipfw/

insns.py

19 lines

Diff 163424

View Options

sbin/ipfw/tests/test_add_rule.py