Page MenuHomeFreeBSD
Differential D52822

arch.7: Add CHERI architectures
ClosedPublic
Actions

Authored by brooks on Wed, Oct 1, 9:40 AM.
Tags
None
Referenced Files
F131892260: D52822.id163210.diff
Sun, Oct 12, 12:45 AM
Unknown Object (File)
Sat, Oct 11, 3:14 PM
Unknown Object (File)
Sat, Oct 11, 3:14 PM
Unknown Object (File)
Sat, Oct 11, 3:14 PM
Unknown Object (File)
Sat, Oct 11, 3:14 PM
Unknown Object (File)
Sat, Oct 11, 3:14 PM
Unknown Object (File)
Sat, Oct 11, 3:14 PM
Unknown Object (File)
Sat, Oct 11, 3:14 PM
View All 38 Files
Subscribers
imp
jhb
jrtc27
markj
ziaee

Details

Reviewers
emaste
kib
markj
jhb
Group Reviewers
cheri
Commits
rGfd895b4f0423: arch.7: Add CHERI architectures
Summary

Sponsored by: Innovate UK, DARPA, AFRL

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.Wed, Oct 1, 9:40 AM
Herald added subscribers: ziaee, imp. · View Herald TranscriptWed, Oct 1, 9:40 AM
brooks requested review of this revision.Wed, Oct 1, 9:40 AM
brooks added a parent revision: D52821: arch.7: decouple long and pointer sizes.
Harbormaster completed remote builds in B67440: Diff 163193.Wed, Oct 1, 9:40 AM
brooks added a subscriber: jhb.Wed, Oct 1, 9:42 AM

This and the commits before it in the stack are intended to start documenting CHERI as it impacts the ABI. I'll probably MFC at least the _ILP32__/__LP64__ one.

@jhb this and D52821 are mostly from a commit you made to CheriBSD so I plan to commit them with you as the author.

emaste added inline comments.Wed, Oct 1, 9:51 AM
share/man/man7/arch.7
163

I think this doc would benefit from one more sentence about the relationship between intptr_t and a capability.

brooks updated this revision to Diff 163210.Wed, Oct 1, 10:21 AM
brooks mentioned this in D52821: arch.7: decouple long and pointer sizes.
  • Restore CHERI bits from D52821
  • Add some words about intptr_t being a capability type
Harbormaster completed remote builds in B67445: Diff 163210.Wed, Oct 1, 10:22 AM
kib added inline comments.Thu, Oct 2, 4:19 AM
share/man/man7/arch.7
62
78

E.g. ptrdiff_t would be still the right type to express the distance between array elements.

202

I would not call aarch64 legacy, this is not a marketing flyer.

brooks updated this revision to Diff 163327.Thu, Oct 2, 9:54 AM

Revise wording around ptrdiff_t, etc use.

Harbormaster completed remote builds in B67480: Diff 163327.Thu, Oct 2, 9:54 AM
markj added a subscriber: markj.Thu, Oct 2, 11:07 PM
markj added inline comments.
share/man/man7/arch.7
61–65
68
74
brooks updated this revision to Diff 163416.Fri, Oct 3, 8:09 AM

Address suggestions from markj and kib

Harbormaster completed remote builds in B67513: Diff 163416.Fri, Oct 3, 8:09 AM
brooks marked 6 inline comments as done.Fri, Oct 3, 8:10 AM
markj accepted this revision as: markj.Fri, Oct 3, 1:09 PM
This revision is now accepted and ready to land.Fri, Oct 3, 1:09 PM
kib accepted this revision.Fri, Oct 3, 3:03 PM
kib added inline comments.
share/man/man7/arch.7
100

Might be add (planned) to avoid confusion until the import is actually done

emaste accepted this revision as: emaste.Fri, Oct 3, 3:06 PM
emaste added inline comments.
share/man/man7/arch.7
100

Yeah I like that idea.

brooks updated this revision to Diff 163447.Fri, Oct 3, 3:30 PM

Add (planned) to CHERI architectures

This revision now requires review to proceed.Fri, Oct 3, 3:30 PM
Harbormaster completed remote builds in B67520: Diff 163447.Fri, Oct 3, 3:30 PM
brooks marked 3 inline comments as done.Fri, Oct 3, 3:31 PM
jhb accepted this revision as: jhb.Mon, Oct 6, 2:55 PM
jhb added inline comments.
share/man/man7/arch.7
433

Is there a __riscv_clen in RV64Y?

This revision is now accepted and ready to land.Mon, Oct 6, 2:55 PM
brooks updated this revision to Diff 163686.Tue, Oct 7, 9:40 AM

Mention __riscv_clen. It definitly exists in CHERI LLVM, I didn't have
an easy way to check RV64Y so go with this for now.

This revision now requires review to proceed.Tue, Oct 7, 9:40 AM
Harbormaster completed remote builds in B67606: Diff 163686.Tue, Oct 7, 9:40 AM
brooks marked an inline comment as done.Tue, Oct 7, 9:49 AM
jrtc27 added a subscriber: jrtc27.Tue, Oct 7, 1:25 PM
jrtc27 added inline comments.
share/man/man7/arch.7
433

Probably __riscv_ylen thanks to the architecture review committee's opinions on making names less useful, but no real reason to query it, only ever going to be 2 * XLEN, which is the more useful one to query as it's what's in the triple.

jrtc27 added inline comments.Tue, Oct 7, 1:26 PM
share/man/man7/arch.7
433

Point is, documenting it here will encourage people to use it, which is not what we want except in rare circumstances. Distinguishing riscv64 vs riscv64c should be done via __CHERI__.

brooks updated this revision to Diff 163692.Tue, Oct 7, 1:31 PM

Drop riscv_clen and add CHERI__

Harbormaster completed remote builds in B67610: Diff 163692.Tue, Oct 7, 1:31 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Oct 8, 9:34 AM
Closed by commit rGfd895b4f0423: arch.7: Add CHERI architectures (authored by jhb, committed by brooks). · Explain Why
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rGfd895b4f0423: arch.7: Add CHERI architectures.

Revision Contents
Changeset List

PathSize
share/
man/
man7/
68 lines

Diff 163753

View Options

share/man/man7/arch.7

Loading...