arm64: Add table attributes to the EFI maps
ClosedPublic
Actions

Authored by andrew on Fri, Sep 26, 11:46 AM.

Details

Reviewers

tuexen
manu

Group Reviewers

arm64

Commits

rG2554148bd85b: arm64: Add table attributes to the EFI maps

Summary

Use table attributes to also limit unprivileged access to the EFI
runtime mappings. This is mostly for parity with pmap as this is never
mapped while userspace could execute.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Fri, Sep 26, 11:46 AM

Herald added a reviewer: manu. · View Herald TranscriptFri, Sep 26, 11:46 AM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Fri, Sep 26, 11:46 AM

Harbormaster completed remote builds in B67350: Diff 162882.Fri, Sep 26, 11:46 AM

andrew added a parent revision: D52750: arm64: Mark EFI memory as userspace non-executable.Fri, Sep 26, 11:46 AM

I tested this patch in combination with D52750 and it resolves the issue. Thanks for the fix.

This revision is now accepted and ready to land.Fri, Sep 26, 1:45 PM

Closed by commit rG2554148bd85b: arm64: Add table attributes to the EFI maps (authored by andrew). · Explain WhyFri, Sep 26, 3:13 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG2554148bd85b: arm64: Add table attributes to the EFI maps.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

efirt_machdep.c

9 lines

Diff 162883

View Options

sys/arm64/arm64/efirt_machdep.c

arm64: Add table attributes to the EFI mapsClosedPublicActions