In VOP_READDIR(), ap->a_eofflag may be null. Check that it isn't
before dereferencing it.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 66821 Build 63704: arc lint + arc unit
Event Timeline
Comment Actions
Because eofflag is documented to be optional and nullable, there may be third-party code that expects that to be the case, and removing the existing null checks would be more work than adding the handful that were missing.
Comment Actions
Where is it documented, in VOP_READDIR.9? Then change the documentation as well.
We do not maintain neither KBI nor KPI compatibility for VFS (or VM), so this change should be even mergeable to stable branches.
Comment Actions
I agree, it is better to make the interface simpler even if it's a bit more work. Third-party code can easily adapt to the new semantics.