ethernet: Prefer memcmp() over bcmp()
ClosedPublic
Actions

Authored by zlei on Sep 2 2025, 5:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Feb 2, 7:17 AM

	Unknown Object (File)
	Sun, Feb 1, 2:04 AM

	Unknown Object (File)
	Fri, Jan 30, 11:35 AM

	Unknown Object (File)
	Fri, Jan 30, 8:27 AM

	Unknown Object (File)
	Mon, Jan 26, 1:52 AM

	Unknown Object (File)
	Dec 24 2025, 4:38 PM

	Unknown Object (File)
	Nov 12 2025, 12:55 AM

	Unknown Object (File)
	Oct 31 2025, 7:04 AM

View All 32 Files

Subscribers

imp

melifaro

Details

Reviewers

glebius

Group Reviewers

network

Commits

rGe05d4c4c08b2: ethernet: Prefer memcmp() over bcmp()
rG51098f0529f0: ethernet: Prefer memcmp() over bcmp()

Summary

The link address should not overlap with mbuf. Prefer memcmp() over
bcmp() for slight performance gain.

No functional change intended.

MFC after: 2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Sep 2 2025, 5:29 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptSep 2 2025, 5:29 PM

zlei requested review of this revision.Sep 2 2025, 5:29 PM

glebius accepted this revision as: glebius.Sep 2 2025, 8:27 PM

This revision is now accepted and ready to land.Sep 2 2025, 8:27 PM

Closed by commit rG51098f0529f0: ethernet: Prefer memcmp() over bcmp() (authored by zlei). · Explain WhySep 3 2025, 5:10 PM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rG51098f0529f0: ethernet: Prefer memcmp() over bcmp().

zlei added a commit: rGe05d4c4c08b2: ethernet: Prefer memcmp() over bcmp().Sep 27 2025, 3:14 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

if_ethersubr.c

2 lines

Diff 161440

View Options

ethernet: Prefer memcmp() over bcmp()ClosedPublicActions