Page MenuHomeFreeBSD

tcp: micro-optimize SYN-cookie expansion
ClosedPublic

Authored by tuexen on Aug 30 2025, 10:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 8:16 PM
Unknown Object (File)
Fri, Oct 10, 5:33 PM
Unknown Object (File)
Fri, Oct 10, 3:43 PM
Unknown Object (File)
Fri, Oct 10, 12:24 PM
Unknown Object (File)
Fri, Oct 10, 12:24 PM
Unknown Object (File)
Fri, Oct 10, 12:24 PM
Unknown Object (File)
Fri, Oct 10, 5:37 AM
Unknown Object (File)
Fri, Oct 10, 5:05 AM

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 1 2025, 6:42 AM
sys/netinet/tcp_syncache.c
2327

I'd suggest to make it u_int. Negative right operand of << is undefined behavior. I know we don't got into negative here, but using unsigned operand would make it tidier.

Use u_int instead of int as the type for wscale as suggested by glebius@.

This revision now requires review to proceed.Sep 1 2025, 8:45 PM
This revision is now accepted and ready to land.Sep 1 2025, 10:13 PM
This revision was automatically updated to reflect the committed changes.