Page MenuHomeFreeBSD

tcp: micro-optimize SYN-cookie expansion
ClosedPublic

Authored by tuexen on Aug 30 2025, 10:32 PM.
Tags
None
Referenced Files
F154687637: D52296.diff
Wed, Apr 29, 5:37 AM
F154685991: D52296.diff
Wed, Apr 29, 5:31 AM
Unknown Object (File)
Tue, Apr 28, 7:23 PM
Unknown Object (File)
Tue, Apr 28, 7:15 PM
Unknown Object (File)
Mon, Apr 27, 4:24 AM
Unknown Object (File)
Sun, Apr 26, 3:19 AM
Unknown Object (File)
Sat, Apr 25, 12:06 AM
Unknown Object (File)
Wed, Apr 22, 11:15 AM

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 1 2025, 6:42 AM
sys/netinet/tcp_syncache.c
2327

I'd suggest to make it u_int. Negative right operand of << is undefined behavior. I know we don't got into negative here, but using unsigned operand would make it tidier.

Use u_int instead of int as the type for wscale as suggested by glebius@.

This revision now requires review to proceed.Sep 1 2025, 8:45 PM
This revision is now accepted and ready to land.Sep 1 2025, 10:13 PM
This revision was automatically updated to reflect the committed changes.