mrsas.4: Cleaning
ClosedPublic
Actions

Authored by ziaee on Aug 22 2025, 4:32 PM.

Details

Reviewers

michaelo
jrm
eugen_grosbein.net
scottl
otis
sumit.saxena_broadcom.com
kadesai
chandrakanth.patil_broadcom.com
imp

Group Reviewers

manpages

Commits

rG224d270f6c6c: mrsas.4: Cleaning
rG52eb7e394a7e: mrsas.4: Cleaning

Summary

+ Rewrite SYNOPSIS for consistency
+ Rewrite HARDWARE for HW Relnotes, and add some stragglers
+ Correct mdoc grammar, making sysctls aproposable and linking xrefs
+ Clean up TODO, cannonicalize to CAVEATS, a standard section
+ Editorial pass, tag SPDX

TODO:

I don't believe these sysctls, can someone verify?
Little help with the hardware?

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ziaee created this revision.Aug 22 2025, 4:32 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 22 2025, 4:32 PM

ziaee requested review of this revision.Aug 22 2025, 4:32 PM

Harbormaster completed remote builds in B66458: Diff 160828.Aug 22 2025, 4:32 PM

So are these sysctls or tunables? E.g. changeable(is there a better word for that?) at runtime?

correct overzealous use of Nm, please do not abuse Nm, it hurts apropos.

Harbormaster completed remote builds in B66460: Diff 160830.Aug 22 2025, 4:41 PM

ziaee retitled this revision from mrsas.4: Cleaning DRAFT to mrsas.4: Cleaning.Aug 22 2025, 4:42 PM

ziaee added a reviewer: kadesai.Aug 22 2025, 5:14 PM

sumit.saxena_broadcom.com added a reviewer: chandrakanth.patil_broadcom.com.Aug 25 2025, 7:15 AM

sumit.saxena_broadcom.com added inline comments.Aug 25 2025, 7:28 AM

share/man/man4/mrsas.4
62–66	As per Broadcom's terminology, 'third to seventh generation' statement is not correct, so it may add confusion. I would like to retain - '6Gb/s and 12 Gb/s'.
64	s/ PCI Express SAS/SATA / PCI Express SAS/SATA/NVMe
96	s/ LSI / Broadcom/LSI
128	Avoid 'third-to-seventh-generation'.
368	Sections for "Ventura" and "Aero" Controllers also can be added.

imp added inline comments.Aug 25 2025, 10:22 AM

share/man/man4/mrsas.4
368	Is that something that you could help with? Or are they both 12Gb/s MegaRAID HBA cards with new device IDs (presumably 0x0060 and 0x0061)

imp added inline comments.Aug 25 2025, 10:33 AM

share/man/man4/mrsas.4
368	Ah, the IDs aren't those (just double checked the driver). Maybe best to just leave them out.
386	I think the old Linux text here is better. However, the driver does have linux emulation code, it seems. It will only work if the ioctls are the same between FreeBSD and Linux, though. And a quick peek in the Linux driver says they differ. But it's the Megaraid Linux IOCTLs that aren't supported so Linux binaries used to manage the card don't work (or if they do, I don't see where the translation is).