Paths

Table of Contentst

Differential D51828

build: Switch CLEAN back on by default
ClosedPublic
Actions

Authored by des on Aug 8 2025, 3:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Oct 18, 3:38 AM

	Unknown Object (File)
	Tue, Oct 14, 4:52 AM

	Unknown Object (File)
	Sun, Oct 12, 1:22 AM

	Unknown Object (File)
	Sun, Oct 12, 1:22 AM

	Unknown Object (File)
	Sun, Oct 12, 1:22 AM

	Unknown Object (File)
	Sat, Oct 11, 3:52 PM

	Unknown Object (File)
	Wed, Oct 8, 8:45 PM

	Unknown Object (File)
	Fri, Oct 3, 10:18 AM

View All 29 Files

Subscribers

Details

Reviewers

markj
jhb

Group Reviewers

Commits

rG6dab48b9de6c: build: Switch CLEAN back on by default

Summary

There have been too many issues with non-META_MODE incremental builds
recently, and it is clear that most users, even developers, were not
aware that the default had been switched.

This will be revisited once more work has been done to help prevent
future breakage.

This reverts commit ba373fca78a114768244d6a8c27983da870c1169.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Aug 8 2025, 3:41 PM

Herald added subscribers: ziaee, emaste, imp, bdrewery. · View Herald TranscriptAug 8 2025, 3:41 PM

des requested review of this revision.Aug 8 2025, 3:41 PM

Harbormaster completed remote builds in B66113: Diff 160064.Aug 8 2025, 3:42 PM

Note that ba373fca78a1 should have removed tools/build/options/WITHOUT_CLEAN, but didn't. It would be great if makeman printed a warning if both WITH_FOO and WITHOUT_FOO exist.

markj accepted this revision as: markj.Aug 8 2025, 3:55 PM

This revision is now accepted and ready to land.Aug 8 2025, 3:55 PM

It may be a feature that both WITH_FOO and WITHOUT_FOO exist. It is in cases where it is arch-specific.

jhb accepted this revision.Aug 8 2025, 3:55 PM

Closed by commit rG6dab48b9de6c: build: Switch CLEAN back on by default (authored by des). · Explain WhyAug 8 2025, 4:05 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG6dab48b9de6c: build: Switch CLEAN back on by default.

+1

kevans added a reverting change: D51923: build: Switch CLEAN back off by default, again.Aug 15 2025, 7:37 PM

kevans added a reverting change: rGdc5f8c344299: build: Switch CLEAN back off by default, again.Aug 20 2025, 4:17 AM

Revision Contents
Changeset List

Path

Size

4 lines

share/

man/

man5/

mk/

2 lines

tools/

build/

options/

Diff 160068

UPDATING

Loading...

share/man/man5/src.conf.5

Loading...

share/mk/src.opts.mk

Loading...

tools/build/options/WITH_CLEAN

Loading...