Page MenuHomeFreeBSD

Remove references to `make world`
ClosedPublic

Authored by emaste on May 22 2025, 6:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 17, 1:54 PM
Unknown Object (File)
Tue, Sep 16, 8:28 PM
Unknown Object (File)
Sep 16 2025, 7:14 AM
Unknown Object (File)
Sep 9 2025, 5:22 AM
Unknown Object (File)
Sep 5 2025, 11:13 PM
Unknown Object (File)
Sep 4 2025, 9:06 AM
Unknown Object (File)
Aug 30 2025, 1:52 AM
Unknown Object (File)
Jul 28 2025, 8:57 PM
Subscribers

Details

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.
documentation/content/en/articles/committers-guide/_index.adoc
3170

Pedantically, we currently suggest a compile-test for kernel changes and compile and install for userland - but not actually running either. This could be refined further but should be a non-functional change.

documentation/content/en/books/developers-handbook/policies/_index.adoc
136

I'm not really sure what this was getting at -- above it says core decides if encumbered code can be added. Is this a separate core gate for whether it gets added to the build system?

documentation/content/en/books/developers-handbook/tools/_index.adoc
533

This one is also correcting a small bug. Updating the first part of the sentence to "possible to compile and install" wouldn't be an improvement (and would still be incorrect unless we also mention HISTORICAL_MAKE_WORLD or DESTDIR).

jhb added a subscriber: jhb.
jhb added inline comments.
documentation/content/en/articles/committers-guide/_index.adoc
3170

I think the intention here is to be a bit more prose than a literal command, so I would maybe tweak this a bit to be more like:

If your changes are anywhere else, make sure you can still compile userspace via `make buildworld`.

I would be fine with leaving off the command or putting the command in parantheses.

documentation/content/en/books/developers-handbook/policies/_index.adoc
136

I think this is just trying to contrast with the kernel.

On a related note, this should probably all be up to srcmgr now instead of core@? (Or maybe we should ask core@ what they think about that)

This revision is now accepted and ready to land.May 23 2025, 5:45 PM
This revision was automatically updated to reflect the committed changes.
olce added inline comments.
documentation/content/en/books/developers-handbook/tools/_index.adoc
533

Since the "entire operating system" is mentioned, shouldn't the make command also include the buildkernel target?