Page MenuHomeFreeBSD
Differential D50419

file: Qualify pointers to capsicum rights as const
ClosedPublic
Actions

Authored by markj on May 19 2025, 4:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 6, 12:14 PM
Unknown Object (File)
Sun, Nov 30, 2:13 PM
Unknown Object (File)
Thu, Nov 20, 5:30 AM
Unknown Object (File)
Mon, Nov 17, 2:10 PM
Unknown Object (File)
Nov 3 2025, 11:04 AM
Unknown Object (File)
Oct 29 2025, 9:48 AM
Unknown Object (File)
Oct 29 2025, 7:38 AM
Unknown Object (File)
Oct 29 2025, 7:24 AM
View All 64 Files
Subscribers
glebius
imp
olce

Details

Reviewers
oshogbo
brooks
kib
olce
Commits
rGecc1e61d3140: file: Qualify pointers to capsicum rights as const
rG2060337c0937: file: Qualify pointers to capsicum rights as const
rG5319cb21610a: file: Qualify pointers to capsicum rights as const
Summary

File descriptor lookup routines typically take a set of capsicum rights
as input to the lookup, so that the fd's rights can be atomically
checked. This set should be qualified with const.

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.May 19 2025, 4:31 PM
Herald added subscribers: olce, glebius, imp. · View Herald TranscriptMay 19 2025, 4:31 PM
markj requested review of this revision.May 19 2025, 4:31 PM
Harbormaster completed remote builds in B64293: Diff 155699.May 19 2025, 4:31 PM
markj added a child revision: D50420: capsicum: Statically initialize commonly used capability rights.May 19 2025, 4:31 PM
oshogbo accepted this revision.May 19 2025, 4:55 PM
This revision is now accepted and ready to land.May 19 2025, 4:55 PM
olce accepted this revision.May 19 2025, 7:36 PM
brooks accepted this revision.May 19 2025, 9:41 PM
kib accepted this revision.May 19 2025, 10:53 PM
Closed by commit rG5319cb21610a: file: Qualify pointers to capsicum rights as const (authored by markj). · Explain WhyMay 20 2025, 8:26 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG5319cb21610a: file: Qualify pointers to capsicum rights as const.
markj added a commit: rG2060337c0937: file: Qualify pointers to capsicum rights as const.Jun 20 2025, 1:52 PM
markj added a commit: rGecc1e61d3140: file: Qualify pointers to capsicum rights as const.Mon, Nov 17, 4:40 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
52 lines
5 lines
5 lines
6 lines
7 lines
5 lines
sys/
21 lines
19 lines
4 lines
6 lines
4 lines

Diff 155768

View Options

sys/kern/kern_descrip.c

Loading...
View Options

sys/kern/sys_procdesc.c

Loading...
View Options

sys/kern/uipc_mqueue.c

Loading...
View Options

sys/kern/uipc_sem.c

Loading...
View Options

sys/kern/uipc_syscalls.c

Loading...
View Options

sys/kern/vfs_syscalls.c

Loading...
View Options

sys/sys/file.h

Loading...
View Options

sys/sys/filedesc.h

Loading...
View Options

sys/sys/namei.h

Loading...
View Options

sys/sys/procdesc.h

Loading...
View Options

sys/sys/socketvar.h

Loading...