This truncation is mostly harmless today, but fix it anyway to avoid
pain later down the road.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 64291 Build 61175: arc lint + arc unit
Event Timeline
sys/fs/fuse/fuse_vnops.c | ||
---|---|---|
1434 | Also I cannot match the local sources for fuse_vnops.c with the patch. In my copy there is also a line int flags = cnp->cn_flags; which clearly needs fixing. |
Comment Actions
Thanks.
sys/fs/fuse/fuse_vnops.c | ||
---|---|---|
1434 |
It is also in the base here, but Mark removed it. This might be a potential subtle change in semantics, as cn_flags is modified below between former uses of flags (the only test performed on flags was whether ISDOTDOT was present, which I suspect is never changed, but didn't check thoroughly). |
sys/fs/fuse/fuse_vnops.c | ||
---|---|---|
1434 | I got rid of the local flags variable, indeed, as the code below uses both flags and cnp->cn_flags, which seems confusing. |