Page MenuHomeFreeBSD

namei: Fix cn_flags width in various places
Needs ReviewPublic

Authored by markj on Mon, May 19, 3:59 PM.

Details

Reviewers
jamie
kib
olce
Summary

This truncation is mostly harmless today, but fix it anyway to avoid
pain later down the road.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64291
Build 61175: arc lint + arc unit

Event Timeline

markj requested review of this revision.Mon, May 19, 3:59 PM
sys/fs/fuse/fuse_vnops.c
1434

Also I cannot match the local sources for fuse_vnops.c with the patch. In my copy there is also a line

	int flags = cnp->cn_flags;

which clearly needs fixing.

Thanks.

sys/fs/fuse/fuse_vnops.c
1434

Also I cannot match the local sources for fuse_vnops.c with the patch.

It is also in the base here, but Mark removed it. This might be a potential subtle change in semantics, as cn_flags is modified below between former uses of flags (the only test performed on flags was whether ISDOTDOT was present, which I suspect is never changed, but didn't check thoroughly).

sys/fs/fuse/fuse_vnops.c
1434

I got rid of the local flags variable, indeed, as the code below uses both flags and cnp->cn_flags, which seems confusing.