Page MenuHomeFreeBSD
Differential D50343

ng_sample: improve styling
ClosedPublic
Actions

Authored by pouria on May 14 2025, 10:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 23, 9:12 AM
Unknown Object (File)
Mon, Sep 21, 3:01 PM
Unknown Object (File)
Sat, Sep 19, 2:20 AM
Unknown Object (File)
Fri, Sep 11, 1:50 PM
Unknown Object (File)
Thu, Sep 10, 3:00 AM
Unknown Object (File)
Wed, Sep 9, 7:09 PM
Unknown Object (File)
Tue, Sep 8, 11:27 PM
Unknown Object (File)
Tue, Sep 8, 2:21 PM
View All Files
Subscribers
des
donner
glebius
imp
ivy
kp
melifaro

Details

Reviewers
ivy
kp
des
Group Reviewers
network
Commits
rG9f290050a6cd: ng_sample: fix style nits
rG49d9f344f67e: ng_sample: fix style nits
rG95c414dd27c2: ng_sample: fix style nits
Summary

Most of the developers used the (resp == NULL) style in their code. New developers will try to follow the ng_sample and may use the (!resp) style which is not consistent with other netgraph modules, also not recommended by MISRA-C.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pouria created this revision.May 14 2025, 10:08 AM
Herald added subscribers: melifaro, donner, imp. · View Herald TranscriptMay 14 2025, 10:08 AM
pouria requested review of this revision.May 14 2025, 10:08 AM
Harbormaster completed remote builds in B64158: Diff 155429.May 14 2025, 10:08 AM
ivy accepted this revision.May 14 2025, 2:45 PM
ivy added a subscriber: ivy.
ivy added inline comments.
sys/netgraph/ng_sample.c
323

while you're here, i believe this extra space is a typo that could be removed.

This revision is now accepted and ready to land.May 14 2025, 2:45 PM
kp accepted this revision.May 14 2025, 4:13 PM
kp added a subscriber: kp.

We don't follow MISRA-C, but style(9) does also require this, so the change should be made anyway.

pouria updated this revision to Diff 155513.May 15 2025, 2:18 PM
  • ng_sample: apply style(9)
This revision now requires review to proceed.May 15 2025, 2:18 PM
Harbormaster completed remote builds in B64200: Diff 155513.May 15 2025, 2:18 PM
pouria marked an inline comment as done.May 15 2025, 2:18 PM

Done

pouria removed a reviewer: glebius.May 15 2025, 2:19 PM
Herald added a subscriber: glebius. · View Herald TranscriptMay 15 2025, 2:19 PM
des accepted this revision.May 16 2025, 12:26 PM
des added a subscriber: des.

@ivy why don't you land this

This revision is now accepted and ready to land.May 16 2025, 12:26 PM
pouria retitled this revision from ng_sample: As defined in MISRA-C, use resp == NULL to ng_sample: ng_sample: improve styling.May 16 2025, 8:11 PM
pouria retitled this revision from ng_sample: ng_sample: improve styling to ng_sample: improve styling.May 16 2025, 8:18 PM
Closed by commit rG95c414dd27c2: ng_sample: fix style nits (authored by pouria, committed by ivy). · Explain WhyMay 16 2025, 8:33 PM
This revision was automatically updated to reflect the committed changes.
ivy added a commit: rG95c414dd27c2: ng_sample: fix style nits.
zarychtam_plan-b.pwste.edu.pl mentioned this in D50108: ip6: implement RFC 8981-advised temporary IID generation.May 16 2025, 11:02 PM
ivy added a commit: rG49d9f344f67e: ng_sample: fix style nits.May 19 2025, 9:31 AM
ivy added a commit: rG9f290050a6cd: ng_sample: fix style nits.May 21 2025, 12:30 AM

Revision Contents
Changeset List

PathSize
sys/
netgraph/
4 lines

Diff 155582

View Options

sys/netgraph/ng_sample.c

Loading...