Only query fdt_fixup_table on architectures where it's used
ClosedPublic
Actions

Authored by andrew on Jan 21 2016, 11:48 AM.

Details

Reviewers

nwhitehorn
jhibbits
imp
br
• ian

Commits

rS294511: Remove fdt_fixup_table from architectures where it's unneeded. We only make

Summary

We only make use of fdt_fixup_table on PowerPC and ARM. As such we can remove it from other architectures as it's unneeded there.

This will also be applicable on riscv, where it's also unneeded, however the patch for the riscv kernel is still under review.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew updated this revision to Diff 12546.Jan 21 2016, 11:48 AM

andrew retitled this revision from to Only query fdt_fixup_table on architectures where it's used.

andrew updated this object.

andrew edited the test plan for this revision. (Show Details)

andrew added reviewers: br, • ian, jhibbits, nwhitehorn, imp.

andrew set the repository for this revision to rS FreeBSD src repository - subversion.

andrew added a subscriber: emaste.

Thanks! It would be good to get rid of it on PowerPC too. I think it is unnecessary, but I don't have the one board that has a fixup() routine and so can't test it, unfortunately.

This revision is now accepted and ready to land.Jan 21 2016, 4:23 PM

In D5013#106551, @nwhitehorn wrote:

Thanks! It would be good to get rid of it on PowerPC too. I think it is unnecessary, but I don't have the one board that has a fixup() routine and so can't test it, unfortunately.

Yes, I'd like to also remove it from ARM, however we also make use of it on one SoC.

Closed by commit rS294511: Remove fdt_fixup_table from architectures where it's unneeded. We only make (authored by andrew). · Explain WhyJan 21 2016, 4:48 PM

This revision was automatically updated to reflect the committed changes.