ctld: Remove dead code in UCL parsing of hex DSCP values
ClosedPublic
Actions

Authored by jhb on Apr 2 2025, 8:05 PM.

Details

Reviewers

Commits

rGa8ab78a0785f: ctld: Remove dead code in UCL parsing of hex DSCP values
rG251439f1a068: ctld: Remove dead code in UCL parsing of hex DSCP values

Summary

libucl treats strings starting with "0x" as an integer if they do
not contain invalid characters. The code also looks broken as it
only calls strtol if the string exactly matches "0x" without any
trailing characters.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 2 2025, 8:05 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 2 2025, 8:05 PM

jhb requested review of this revision.Apr 2 2025, 8:05 PM

Harbormaster completed remote builds in B63289: Diff 153043.Apr 2 2025, 8:05 PM

jhb added a parent revision: D49643: ctld: Add a label string to auth_groups.Apr 2 2025, 8:05 PM

jhb added a child revision: D49645: ctld: Properly validate mutual user/secret for CHAP-MUTUAL in the UCL parser.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 11 2025, 2:04 PM

Closed by commit rG251439f1a068: ctld: Remove dead code in UCL parsing of hex DSCP values (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG251439f1a068: ctld: Remove dead code in UCL parsing of hex DSCP values.

jhb added a commit: rGa8ab78a0785f: ctld: Remove dead code in UCL parsing of hex DSCP values.Jan 27 2026, 6:45 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

uclparse.cc

3 lines

Diff 153520

View Options

ctld: Remove dead code in UCL parsing of hex DSCP valuesClosedPublicActions