Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 5, 9:53 PM

	Unknown Object (File)
	Nov 4 2025, 1:43 PM

	Unknown Object (File)
	Nov 4 2025, 2:53 AM

	Unknown Object (File)
	Nov 4 2025, 2:53 AM

	Unknown Object (File)
	Nov 4 2025, 2:52 AM

	Unknown Object (File)
	Nov 4 2025, 2:51 AM

	Unknown Object (File)
	Nov 3 2025, 2:33 PM

	Unknown Object (File)
	Oct 29 2025, 8:24 AM

View All 49 Files

Subscribers

imp

Details

Reviewers

asomers

Commits

rGbf4115671292: ctld: Properly validate mutual user/secret for CHAP-MUTUAL in the UCL parser

Summary

The code was checking the non-mutual UCL objects twice instead.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 2 2025, 8:05 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 2 2025, 8:05 PM

jhb requested review of this revision.Apr 2 2025, 8:05 PM

Harbormaster completed remote builds in B63290: Diff 153044.Apr 2 2025, 8:05 PM

jhb added a parent revision: D49644: ctld: Remove dead code in UCL parsing of hex DSCP values.Apr 2 2025, 8:05 PM

jhb added a child revision: D49646: ctld: Drop commented-out code to print the configuration.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 11 2025, 2:04 PM

Closed by commit rGbf4115671292: ctld: Properly validate mutual user/secret for CHAP-MUTUAL in the UCL parser (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGbf4115671292: ctld: Properly validate mutual user/secret for CHAP-MUTUAL in the UCL parser.

ctld: Properly validate mutual user/secret for CHAP-MUTUAL in the UCL parser
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 153521

usr.sbin/ctld/uclparse.cc

ctld: Properly validate mutual user/secret for CHAP-MUTUAL in the UCL parserClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 153521

usr.sbin/ctld/uclparse.cc

ctld: Properly validate mutual user/secret for CHAP-MUTUAL in the UCL parser
ClosedPublic
Actions

Revision Contents
Changeset List