Differential D49645

ctld: Properly validate mutual user/secret for CHAP-MUTUAL in the UCL parser
ClosedPublic
Actions

Authored by jhb on Apr 2 2025, 8:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 11, 4:10 AM

	Unknown Object (File)
	Fri, Sep 11, 2:59 AM

	Unknown Object (File)
	Sat, Sep 5, 6:48 PM

	Unknown Object (File)
	Sat, Sep 5, 6:47 PM

	Unknown Object (File)
	Sat, Sep 5, 9:57 AM

	Unknown Object (File)
	Sat, Sep 5, 9:31 AM

	Unknown Object (File)
	Sat, Sep 5, 8:06 AM

	Unknown Object (File)
	Fri, Sep 4, 10:11 AM

Subscribers

Details

Reviewers

Commits

rG88b3dab8d0ec: ctld: Properly validate mutual user/secret for CHAP-MUTUAL in the UCL parser
rGbf4115671292: ctld: Properly validate mutual user/secret for CHAP-MUTUAL in the UCL parser

Summary

The code was checking the non-mutual UCL objects twice instead.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 2 2025, 8:05 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 2 2025, 8:05 PM

jhb requested review of this revision.Apr 2 2025, 8:05 PM

Harbormaster completed remote builds in B63290: Diff 153044.Apr 2 2025, 8:05 PM

jhb added a parent revision: D49644: ctld: Remove dead code in UCL parsing of hex DSCP values.Apr 2 2025, 8:05 PM

jhb added a child revision: D49646: ctld: Drop commented-out code to print the configuration.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 11 2025, 2:04 PM

Closed by commit rGbf4115671292: ctld: Properly validate mutual user/secret for CHAP-MUTUAL in the UCL parser (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGbf4115671292: ctld: Properly validate mutual user/secret for CHAP-MUTUAL in the UCL parser.

jhb added a commit: rG88b3dab8d0ec: ctld: Properly validate mutual user/secret for CHAP-MUTUAL in the UCL parser.Jan 27 2026, 6:45 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

8 lines

Diff 153521

usr.sbin/ctld/uclparse.cc

Loading...