Differential D49650

ctld: Do not remove item from an nvlist while iterating it
ClosedPublic
Actions

Authored by jhb on Apr 2 2025, 8:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 11, 12:21 PM

	Unknown Object (File)
	Fri, Sep 11, 12:57 AM

	Unknown Object (File)
	Tue, Sep 8, 10:38 PM

	Unknown Object (File)
	Tue, Sep 8, 6:54 AM

	Unknown Object (File)
	Tue, Sep 8, 6:28 AM

	Unknown Object (File)
	Sun, Sep 6, 11:20 PM

	Unknown Object (File)
	Sun, Sep 6, 8:48 PM

	Unknown Object (File)
	Sun, Sep 6, 5:25 AM

Subscribers

Details

Reviewers

Commits

rG4054439b47f2: ctld: Do not remove item from an nvlist while iterating it
rG30020689fb1e: ctld: Do not remove item from an nvlist while iterating it

Summary

While here, make use of cnvlist_* to simplify this code.

Fixes: d42a73fb6a85 ("ctld: Add a dedicated API between parse.y and the rest of the program")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 2 2025, 8:36 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 2 2025, 8:36 PM

jhb requested review of this revision.Apr 2 2025, 8:36 PM

Harbormaster completed remote builds in B63296: Diff 153054.Apr 2 2025, 8:36 PM

jhb added a parent revision: D49649: ctld: Remove dead logging code.Apr 2 2025, 8:36 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 11 2025, 2:04 PM

Closed by commit rG30020689fb1e: ctld: Do not remove item from an nvlist while iterating it (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG30020689fb1e: ctld: Do not remove item from an nvlist while iterating it.

jhb added a commit: rG4054439b47f2: ctld: Do not remove item from an nvlist while iterating it.Jan 27 2026, 6:45 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

7 lines

Diff 153526

usr.sbin/ctld/kernel.cc

Loading...