ctld: Reduce code duplication in auth_check_secret_length
ClosedPublic
Actions

Authored by jhb on Apr 2 2025, 8:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 4, 2:51 AM

	Unknown Object (File)
	Tue, Nov 4, 2:51 AM

	Unknown Object (File)
	Tue, Nov 4, 2:50 AM

	Unknown Object (File)
	Tue, Nov 4, 2:50 AM

	Unknown Object (File)
	Tue, Nov 4, 2:50 AM

	Unknown Object (File)
	Tue, Nov 4, 2:49 AM

	Unknown Object (File)
	Mon, Nov 3, 10:31 PM

	Unknown Object (File)
	Fri, Oct 31, 5:34 AM

View All 53 Files

Subscribers

imp

Details

Reviewers

asomers

Commits

rG4214775235eb: ctld: Reduce code duplication in auth_check_secret_length

Summary

Only check a single secret length in the function and call it twice
for the CHAP-MUTUAL case.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 2 2025, 8:04 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 2 2025, 8:04 PM

jhb requested review of this revision.Apr 2 2025, 8:04 PM

Harbormaster completed remote builds in B63287: Diff 153041.Apr 2 2025, 8:04 PM

jhb added a parent revision: D49641: ctld: Fix sign bug validating kernel ports when reloading config.Apr 2 2025, 8:04 PM

jhb added a child revision: D49643: ctld: Add a label string to auth_groups.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 11 2025, 2:04 PM

Closed by commit rG4214775235eb: ctld: Reduce code duplication in auth_check_secret_length (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG4214775235eb: ctld: Reduce code duplication in auth_check_secret_length.

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

ctld.cc

67 lines

Diff 153518

View Options

ctld: Reduce code duplication in auth_check_secret_lengthClosedPublicActions