Page MenuHomeFreeBSD
Differential D49629

bhyve: make most of the iommu_ops interfaces return error
ClosedPublic
Actions

Authored by kib on Apr 2 2025, 12:12 AM.
Tags
None
Referenced Files
F147328506: D49629.id153009.diff
Tue, Mar 10, 12:51 AM
Unknown Object (File)
Sun, Mar 8, 5:05 PM
Unknown Object (File)
Sun, Mar 8, 11:25 AM
Unknown Object (File)
Sun, Mar 8, 5:43 AM
Unknown Object (File)
Wed, Feb 18, 1:46 PM
Unknown Object (File)
Tue, Feb 17, 7:13 AM
Unknown Object (File)
Sun, Feb 8, 7:16 AM
Unknown Object (File)
Feb 7 2026, 11:30 PM
View All 72 Files
Subscribers
bcran
imp
jrm
rgrimes

Details

Reviewers
markj
jhb
emaste
Group Reviewers
bhyve
Commits
rG297473069610: bhyve IOMMU_REMOVE_DEVICE(): ignore iommu absence for sake of ppt_attach()
rG2eeb95ccf39a: bhyve: make most of the iommu_ops interfaces return error
Summary

and change create_mapping()/remove_mapping() to allow shorten results.
bhyve IOMMU_REMOVE_DEVICE(): ignore iommu absence for sake of ppt_attach()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Apr 2 2025, 12:12 AM
Herald added a reviewer: bhyve. · View Herald TranscriptApr 2 2025, 12:12 AM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
kib requested review of this revision.Apr 2 2025, 12:12 AM
markj added inline comments.Apr 2 2025, 7:30 PM
sys/amd64/vmm/io/iommu.c
241

Did you plan to handle it in this patch?

sys/amd64/vmm/vmm.c
866

Should this block be deleted?

kib updated this revision to Diff 153052.Apr 2 2025, 8:15 PM
kib marked 2 inline comments as done.

Fix two todos.

markj accepted this revision as: markj.Apr 5 2025, 3:55 PM
This revision is now accepted and ready to land.Apr 5 2025, 3:55 PM
Closed by commit rG2eeb95ccf39a: bhyve: make most of the iommu_ops interfaces return error (authored by kib). · Explain WhyApr 6 2025, 3:26 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG2eeb95ccf39a: bhyve: make most of the iommu_ops interfaces return error.
kib added a commit: rG297473069610: bhyve IOMMU_REMOVE_DEVICE(): ignore iommu absence for sake of ppt_attach().

Revision Contents
Changeset List

PathSize
sys/
amd64/
vmm/
amd/
39 lines
intel/
28 lines
io/
26 lines
119 lines
33 lines
22 lines

Diff 153200

View Options

sys/amd64/vmm/amd/amdvi_hw.c

Loading...
View Options

sys/amd64/vmm/intel/vtd.c

Loading...
View Options

sys/amd64/vmm/io/iommu.h

Loading...
View Options

sys/amd64/vmm/io/iommu.c

Loading...
View Options

sys/amd64/vmm/io/ppt.c

Loading...
View Options

sys/amd64/vmm/vmm.c

Loading...