Page MenuHomeFreeBSD
Differential D49521

vm_fault: update page pred after lock rel/acq in copy_entry
ClosedPublic
Actions

Authored by dougm on Mar 26 2025, 4:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 18, 4:30 AM
Unknown Object (File)
Wed, Oct 15, 1:14 AM
Unknown Object (File)
Tue, Oct 7, 2:48 PM
Unknown Object (File)
Fri, Oct 3, 12:40 AM
Unknown Object (File)
Tue, Sep 30, 9:17 PM
Unknown Object (File)
Mon, Sep 29, 1:25 AM
Unknown Object (File)
Sun, Sep 28, 3:22 PM
Unknown Object (File)
Fri, Sep 26, 11:14 PM
View All 78 Files
Subscribers
imp
markj

Details

Reviewers
markj
alc
Commits
rG6d6c97fb72a7: vm_fault: update pred lock acq in copy_entry
Summary

In vm_fault_copy_entry, variable 'mpred' is invalided as the predecessor of the next page to be inserted when an allocation failure leads to lock release and reacquisition. Recompute it in that case.

Addresses a problem identified by @markj in D49103.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Mar 26 2025, 4:27 PM
dougm created this revision.
dougm updated this revision to Diff 152703.Mar 26 2025, 4:47 PM

Don't break pindex.

dougm updated this revision to Diff 152705.Mar 26 2025, 5:00 PM

Sorry, that was all to complicated. Simplify.

dougm updated this revision to Diff 152706.Mar 26 2025, 5:07 PM

Update the correct variable.

markj accepted this revision.Mar 27 2025, 8:58 AM

Could you please include a Fixes tag in the commit log?

This revision is now accepted and ready to land.Mar 27 2025, 8:58 AM
Closed by commit rG6d6c97fb72a7: vm_fault: update pred lock acq in copy_entry (authored by dougm). · Explain WhyMar 27 2025, 10:41 AM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rG6d6c97fb72a7: vm_fault: update pred lock acq in copy_entry.
Herald added a subscriber: imp. · View Herald TranscriptMar 27 2025, 10:41 AM
markj added inline comments.Mar 27 2025, 11:50 PM
sys/vm/vm_fault.c
2211

Sorry I didn't catch this - this should be dst_object, not src_object.

Revision Contents
Changeset List

PathSize
sys/
vm/
6 lines

Diff 152734

View Options

sys/vm/vm_fault.c

Loading...