Page MenuHomeFreeBSD

*/*: Rework manpages handling in Samba-related ports
ClosedPublic

Authored by michaelo on Mar 12 2025, 9:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 12:36 PM
Unknown Object (File)
Thu, Oct 9, 2:31 AM
Unknown Object (File)
Sat, Oct 4, 4:15 AM
Unknown Object (File)
Sat, Oct 4, 4:15 AM
Unknown Object (File)
Sat, Oct 4, 4:14 AM
Unknown Object (File)
Sat, Oct 4, 4:12 AM
Unknown Object (File)
Thu, Oct 2, 11:51 AM
Unknown Object (File)
Mon, Sep 29, 11:01 PM
Subscribers
None

Details

Summary
  • Remove outdated, incorrect, precompiled manpages from ${FILESDIR}/files/man.
  • Properly disable manpages generation since XSLTPROC was set to true(1) WAF always assumed xsltproc(1) to work and if any automatic dependency pulled in textproc/docbook-xsl, manpages were generated even if explicitly disabled.

Approved by: jrm (mentor), otis (mentor), ...

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michaelo created this revision.
devel/tevent/Makefile
48–49

I'm confused by this comment. If there are no man pages for this port, why is there an OPTION and the associated logic?

devel/tevent016/Makefile
49–50

Same comment.

devel/tevent/Makefile
48–49

The actual block has been there, I added the comment on purpose for the following reason:

  • consistency with other Samba-related ports
  • if a manpage is added only pkg-plist needs to be modified.
devel/tevent/Makefile
48–49

Let's remove it. If necessary, it's not that hard to copy a couple of lines from the other ports in the future. A MANPAGES option and the associated logic for ports that don't install any manpages is kinda weird.

This revision is now accepted and ready to land.Mar 12 2025, 9:55 PM