Page MenuHomeFreeBSD

netinet tests: Move import
ClosedPublic

Authored by jlduran on Tue, Feb 11, 7:28 PM.
Tags
None
Referenced Files
F110106512: D48945.diff
Thu, Feb 13, 5:06 PM
Unknown Object (File)
Wed, Feb 12, 2:45 PM

Details

Summary

This will allow the test to be skipped if scapy is not installed.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62373
Build 59257: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Tue, Feb 11, 7:37 PM

I think I'd like a slightly more verbose commit message for this.

Perhaps:

Move the import of 'Sniffer', which depends on scapy into the test so we don't try (and fail) to import it unless scapy is installed.

In D48945#1116557, @kp wrote:

I think I'd like a slightly more verbose commit message for this.

Perhaps:

Move the import of 'Sniffer', which depends on scapy into the test so we don't try (and fail) to import it unless scapy is installed.

Excellent, thank you. Will update upon commit.

This revision was automatically updated to reflect the committed changes.