Page MenuHomeFreeBSD

netinet tests: Move import
ClosedPublic

Authored by jlduran on Feb 11 2025, 7:28 PM.
Tags
None
Referenced Files
F132463075: D48945.diff
Fri, Oct 17, 3:39 AM
Unknown Object (File)
Sep 6 2025, 3:09 PM
Unknown Object (File)
Aug 31 2025, 12:27 PM
Unknown Object (File)
Aug 24 2025, 4:22 PM
Unknown Object (File)
Aug 21 2025, 12:00 AM
Unknown Object (File)
Aug 18 2025, 4:34 AM
Unknown Object (File)
Aug 15 2025, 9:09 PM
Unknown Object (File)
Aug 15 2025, 10:13 AM

Details

Summary

This will allow the test to be skipped if scapy is not installed.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Feb 11 2025, 7:37 PM

I think I'd like a slightly more verbose commit message for this.

Perhaps:

Move the import of 'Sniffer', which depends on scapy into the test so we don't try (and fail) to import it unless scapy is installed.

In D48945#1116557, @kp wrote:

I think I'd like a slightly more verbose commit message for this.

Perhaps:

Move the import of 'Sniffer', which depends on scapy into the test so we don't try (and fail) to import it unless scapy is installed.

Excellent, thank you. Will update upon commit.

This revision was automatically updated to reflect the committed changes.