Why
They are used by the DRM drivers in Linux 6.7.
This is part of the update of DRM drivers to Linux 6.7.
Sponsored by: The FreeBSD Foundation
Details
Details
- Reviewers
bz - Group Reviewers
linuxkpi - Commits
- rG05dfaadde4ae: linuxkpi: Add `shrinker_alloc()` and `shrinker_free()`
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Seems fine to me for as much as I can say. Beware that it breaks KBI if struct shrinker is embedded into drivers.
| sys/compat/linuxkpi/common/include/linux/shrinker.h | ||
|---|---|---|
| 57 | I thin in general we do not put the space between * and function name. | |
| 65 | Has VA_OPT moved from C++ to C standard as well? I cannot find any prior use in sys/ but contrib/llvm seems to know about it. Hopefully gcc as well. | |
Comment Actions
At least drm-kmod 6.1-lts struct i915_gem_mm seems to embed struct shrinker. So moving fields will need this recompiled most likely (ttm pool most likely too, though there you could get away with adding the flags field to the end of the structure). I suppose at least bump __FreeBSD_version and document it docs. Not sure how drm-kmod ports are handled in these cases if they need to be recompiled.
Are you planning to MFC this?