Differential D48747

linuxkpi: Add `shrinker_alloc()` and `shrinker_free()`
ClosedPublic
Actions

Authored by dumbbell on Jan 31 2025, 2:14 PM.

Details

Reviewers

Group Reviewers

linuxkpi

Commits

rG05dfaadde4ae: linuxkpi: Add `shrinker_alloc()` and `shrinker_free()`

Summary

Why

They are used by the DRM drivers in Linux 6.7.

This is part of the update of DRM drivers to Linux 6.7.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dumbbell created this revision.Jan 31 2025, 2:14 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptJan 31 2025, 2:14 PM

dumbbell requested review of this revision.Jan 31 2025, 2:14 PM

Add diff context. No other changes.

Seems fine to me for as much as I can say. Beware that it breaks KBI if struct shrinker is embedded into drivers.

sys/compat/linuxkpi/common/include/linux/shrinker.h
57	I thin in general we do not put the space between * and function name.
65	Has VA_OPT moved from C++ to C standard as well? I cannot find any prior use in sys/ but contrib/llvm seems to know about it. Hopefully gcc as well.

This revision is now accepted and ready to land.Feb 8 2025, 8:49 PM

@bz: Is there something I should do to document the breakage?

In D48747#1115683, @dumbbell wrote:

@bz: Is there something I should do to document the breakage?

At least drm-kmod 6.1-lts struct i915_gem_mm seems to embed struct shrinker. So moving fields will need this recompiled most likely (ttm pool most likely too, though there you could get away with adding the flags field to the end of the structure). I suppose at least bump __FreeBSD_version and document it docs. Not sure how drm-kmod ports are handled in these cases if they need to be recompiled.

Are you planning to MFC this?

Closed by commit rG05dfaadde4ae: linuxkpi: Add `shrinker_alloc()` and `shrinker_free()` (authored by dumbbell). · Explain WhyFeb 19 2025, 8:49 PM

This revision was automatically updated to reflect the committed changes.

dumbbell added a commit: rG05dfaadde4ae: linuxkpi: Add `shrinker_alloc()` and `shrinker_free()`.