Paths

Table of Contentst

Differential D47726

nvmecontrol: Fix minor usage typo
ClosedPublic
Actions

Authored by ziaee on Nov 24 2024, 7:30 PM.

Tags

None

Referenced Files

	F156877538: D47726.id147596.diff
	Sun, May 17, 1:09 AM

	F156817063: D47726.id147596.diff
	Sat, May 16, 4:05 PM

	F156816985: D47726.id147596.diff
	Sat, May 16, 4:05 PM

	F156799673: D47726.id.diff
	Sat, May 16, 11:58 AM

	Unknown Object (File)
	Wed, May 13, 9:15 PM

	Unknown Object (File)
	Mon, May 11, 11:35 PM

	Unknown Object (File)
	Mon, May 11, 11:35 PM

	Unknown Object (File)
	Mon, May 11, 11:22 PM

View All 82 Files

Subscribers

Details

Reviewers

markj
jhb
mav
imp
emaste
mhorne
carlavilla

Commits

rGe4520bc1e284: nvmecontrol: Fix minor usage typo
rG1a2d8c4db2ae: nvmecontrol: Fix minor usage typo
rGe7aec3ccf759: nvmecontrol: Fix minor usage typo

Summary

PR: 282930
MFC after: 3 days
Reported by: Gian-Simon Purkert <gspurki@gmail.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ziaee created this revision.Nov 24 2024, 7:30 PM

Herald added a subscriber: dab. · View Herald TranscriptNov 24 2024, 7:30 PM

ziaee requested review of this revision.Nov 24 2024, 7:30 PM

Harbormaster completed remote builds in B60750: Diff 146891.Nov 24 2024, 7:30 PM

imp accepted this revision.Nov 24 2024, 7:45 PM

This revision is now accepted and ready to land.Nov 24 2024, 7:45 PM

jhb accepted this revision.Nov 25 2024, 2:22 PM

Minor comment on commit message - imperative, present tense is preferred, so e.g. nvmecontrol: Fix usage typo (or Fix typo in option description etc.)

Examples, from git log --oneline --grep typo freebsd/main | head -n 10 mostly follow this:

0d6306be8c67 Fix few __VA_ARGS typos in assertions
21ca690b5668 ppp.8: Fix typo cuad0 -> cuau0
0381f0b63b9a arm: Fix typo in ldscript.arm.
12cbad923dbc nanobsd: Fix typos
e434c56fcd4f rtld_get_var.3: fix typo
019981e00f23 git-arc: Fix typo s/Truning/Turning/
57aebec4f767 x86/iommu/amd_reg.h: fix typo in comment
e63d5726b4ff ipsec.4: cross-reference typo
65691b2dafda libexec/rc/rc.d/netif: Typo fix
5fa2e50ea438 genl: fix typo

Thanks emaste!

(adding doc mentors as reviewers)

Closed by commit rGe7aec3ccf759: nvmecontrol: Fix minor usage typo (authored by ziaee, committed by imp). · Explain WhyDec 6 2024, 4:18 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGe7aec3ccf759: nvmecontrol: Fix minor usage typo.

imp added a commit: rG1a2d8c4db2ae: nvmecontrol: Fix minor usage typo.Dec 28 2024, 6:56 PM

imp added a commit: rGe4520bc1e284: nvmecontrol: Fix minor usage typo.Dec 28 2024, 6:59 PM

Revision Contents
Changeset List

Path

Size

sbin/

nvmecontrol/

2 lines

Diff 147596

sbin/nvmecontrol/format.c

Loading...