cdefs: Allow _XOPEN_SOURCE >= 800
ClosedPublic
Actions

Authored by imp on Nov 14 2024, 6:59 PM.

Details

Reviewers

kevans
brooks

Commits

rG94b666c663d2: cdefs: Allow _XOPEN_SOURCE >= 800

Summary

When the user asks for XOPEN_SOURCE >= 800, set __XSI_VISIBLE to 800 for
POSIX 2024.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60562
Build 57446: arc lint + arc unit

Event Timeline

imp requested review of this revision.Nov 14 2024, 6:59 PM

imp created this revision.

Harbormaster completed remote builds in B60562: Diff 146457.Nov 14 2024, 6:59 PM

forgotten fold

Harbormaster completed remote builds in B60567: Diff 146462.Nov 14 2024, 7:00 PM

I wish there was a comment justifying the - 0 pattern...

This revision is now accepted and ready to land.Nov 14 2024, 7:20 PM

In D47574#1085131, @brooks wrote:

I wish there was a comment justifying the - 0 pattern...

I'll add one in a future commit.

In D47574#1085196, @imp wrote:

In D47574#1085131, @brooks wrote:

I wish there was a comment justifying the - 0 pattern...

I'll add one in a future commit.

At this point, it's likely a historic practice we can drop. Peter Wemm added it 22 years
ago:
Deal with "#define _XOPEN_SOURCE" in header files (eg: XFree86 4.2.0)
so I'll add a comment to that effect. I'd just drop it, but a code search says it's
still a common idium.