Page MenuHomeFreeBSD
Differential D47574

cdefs: Allow _XOPEN_SOURCE >= 800
ClosedPublic
Actions

Authored by imp on Nov 14 2024, 6:59 PM.
Tags
None
Referenced Files
F170157750: D47574.id.diff
Thu, Sep 3, 4:47 PM
F170139729: D47574.id146462.diff
Thu, Sep 3, 3:22 PM
F170073295: D47574.id146481.diff
Thu, Sep 3, 10:46 AM
F169968053: D47574.id.diff
Thu, Sep 3, 3:24 AM
Unknown Object (File)
Wed, Sep 2, 3:20 PM
Unknown Object (File)
Tue, Sep 1, 3:19 PM
Unknown Object (File)
Tue, Sep 1, 10:45 AM
Unknown Object (File)
Tue, Sep 1, 9:50 AM
View All Files
Subscribers
brooks

Details

Reviewers
kevans
brooks
Commits
rG94b666c663d2: cdefs: Allow _XOPEN_SOURCE >= 800
Summary

When the user asks for XOPEN_SOURCE >= 800, set __XSI_VISIBLE to 800 for
POSIX 2024.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Nov 14 2024, 6:59 PM
imp created this revision.
Harbormaster completed remote builds in B60562: Diff 146457.Nov 14 2024, 6:59 PM
imp updated this revision to Diff 146462.Nov 14 2024, 6:59 PM
imp added a child revision: D47575: cdesf: Support _POSIX_C_SOURCE 202405 for POSIX 2024.

forgotten fold

Harbormaster completed remote builds in B60567: Diff 146462.Nov 14 2024, 7:00 PM
brooks accepted this revision.Nov 14 2024, 7:20 PM
brooks added a subscriber: brooks.

I wish there was a comment justifying the - 0 pattern...

This revision is now accepted and ready to land.Nov 14 2024, 7:20 PM
imp added a comment.Nov 14 2024, 10:11 PM
In D47574#1085131, @brooks wrote:

I wish there was a comment justifying the - 0 pattern...

I'll add one in a future commit.

imp added a comment.Nov 14 2024, 10:38 PM
In D47574#1085196, @imp wrote:
In D47574#1085131, @brooks wrote:

I wish there was a comment justifying the - 0 pattern...

I'll add one in a future commit.

At this point, it's likely a historic practice we can drop. Peter Wemm added it 22 years
ago:
Deal with "#define _XOPEN_SOURCE" in header files (eg: XFree86 4.2.0)
so I'll add a comment to that effect. I'd just drop it, but a code search says it's
still a common idium.

imp added a comment.Nov 14 2024, 11:39 PM

https://reviews.freebsd.org/D47584 ads the comment that Brooks suggested.

Closed by commit rG94b666c663d2: cdefs: Allow _XOPEN_SOURCE >= 800 (authored by imp). · Explain WhyNov 15 2024, 2:02 AM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG94b666c663d2: cdefs: Allow _XOPEN_SOURCE >= 800.

Revision Contents
Changeset List

PathSize
sys/
sys/
6 lines

Diff 146481

View Options

sys/sys/cdefs.h

Loading...