Page MenuHomeFreeBSD
Differential D47495

pf: fix potential state key leak
ClosedPublic
Actions

Authored by kp on Sat, Nov 9, 10:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 1:10 PM
Unknown Object (File)
Sat, Nov 23, 2:34 PM
Unknown Object (File)
Sun, Nov 17, 3:37 AM
Unknown Object (File)
Sat, Nov 16, 12:46 AM
Unknown Object (File)
Thu, Nov 14, 12:52 PM
Unknown Object (File)
Wed, Nov 13, 10:34 AM
Unknown Object (File)
Mon, Nov 11, 12:27 PM
Unknown Object (File)
Mon, Nov 11, 11:43 AM
View All 13 Files
Subscribers
farrokhi
glebius
imp
melifaro
vegeta_tuxpowered.net

Details

Reviewers
None
Group Reviewers
network
pfsense
Commits
rGb4b2e420195a: pf: fix potential state key leak
rG93c80b79ad65: pf: fix potential state key leak
rG371bd29d4b22: pf: fix potential state key leak
Summary

If we fail to attach the new state keys in pf_state_key_attach() we are
expected to free both keys. Do so.
Note that in some scenarios both key are the same, so check for that
before freeing.

MFC after: 2 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
netpfil/
pf/
4 lines

Diff 146346

View Options

sys/netpfil/pf/pf.c

Loading...