linux sendfile: Fix handling of non-blocking sockets
ClosedPublic
Actions

Authored by markj on Nov 5 2024, 1:59 AM.

Details

Reviewers

glebius
dchagin

Commits

rG91a805447374: linux sendfile: Fix handling of non-blocking sockets
rGa43b745aaf4f: linux sendfile: Fix handling of non-blocking sockets

Summary

FreeBSD sendfile() may perform a partial transfer and return EAGAIN if
the socket is non-blocking. Linux sendfile expects no error in this
case, so squash EAGAIN.

PR: 282495

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Nov 5 2024, 1:59 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 5 2024, 1:59 AM

markj requested review of this revision.Nov 5 2024, 1:59 AM

Harbormaster completed remote builds in B60391: Diff 146031.Nov 5 2024, 1:59 AM

markj added inline comments.Nov 5 2024, 2:02 AM

sys/compat/linux/linux_socket.c
2596	This comes from commit 4f9fac78d4da6, but I don't really understand it: what exactly is triggering ENOBUFS?

Return EAGAIN if no bytes were sent

Harbormaster completed remote builds in B60482: Diff 146240.Nov 10 2024, 3:16 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 13 2024, 2:16 PM

Closed by commit rGa43b745aaf4f: linux sendfile: Fix handling of non-blocking sockets (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGa43b745aaf4f: linux sendfile: Fix handling of non-blocking sockets.

markj added a commit: rG91a805447374: linux sendfile: Fix handling of non-blocking sockets.Nov 20 2024, 9:41 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

linux_socket.c

7 lines

Diff 146356

View Options

sys/compat/linux/linux_socket.c

linux sendfile: Fix handling of non-blocking socketsClosedPublicActions