Paths

Table of Contentst

Differential D46970

kinfo_vmentry: report posix shm and path
ClosedPublic
Actions

Authored by kib on Mon, Oct 7, 8:32 AM.

Tags

None

Referenced Files

	F99334511: D46970.diff
	Tue, Oct 8, 12:39 PM

	F99304537: D46970.id.diff
	Tue, Oct 8, 5:41 AM

	F99284035: D46970.diff
	Tue, Oct 8, 12:41 AM

Subscribers

Details

Reviewers

markj
emaste

Commits

rGba40b2b89962: vmstat -o: report objects backing posix shm segments
rGa1258191d5e2: procstat vm: report posix shm segment mapping
rGb0b18b57a55b: sysctl vm.objects: report objects backing posix shm segments
rGa8c641bbcba7: sys/user.h: report posix shm mappings
rGbda73e441f25: posix shm: add shm_get_path(9)
rGa10870ecea81: posix shm: mark backing objects with SHM_POSIXSHM flag
rG71a66883b58f: kinfo_{vmobject,vmentry}: move copy of pathes into the vnode handling scope

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Mon, Oct 7, 8:32 AM

Herald added subscribers: olce, glebius, imp. · View Herald TranscriptMon, Oct 7, 8:32 AM

kib requested review of this revision.Mon, Oct 7, 8:32 AM

markj added inline comments.Tue, Oct 8, 12:23 PM

sys/kern/uipc_shm.c
952 ↗	(On Diff #144369)	Why can't we use `obj->handle` rather than adding this new field? Looks like it is currently NULL for all POSIX shm objects.
2242 ↗	(On Diff #144369)	Extra newline.

kib marked 2 inline comments as done.Tue, Oct 8, 12:30 PM

kib added inline comments.

sys/kern/uipc_shm.c
952 ↗	(On Diff #144369)	Phys pager assumes that the object with a handle is on list. Fighting with it is IMO not worth it, the new field is in union' free space.

kib marked an inline comment as done.Tue, Oct 8, 12:32 PM

markj accepted this revision.Tue, Oct 8, 12:36 PM

This revision is now accepted and ready to land.Tue, Oct 8, 12:36 PM

Closed by commit rG71a66883b58f: kinfo_{vmobject,vmentry}: move copy of pathes into the vnode handling scope (authored by kib). · Explain WhyTue, Oct 8, 12:39 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG71a66883b58f: kinfo_{vmobject,vmentry}: move copy of pathes into the vnode handling scope.

kib added a commit: rGa10870ecea81: posix shm: mark backing objects with SHM_POSIXSHM flag.

kib added a commit: rGbda73e441f25: posix shm: add shm_get_path(9).

kib added a commit: rGa8c641bbcba7: sys/user.h: report posix shm mappings.

kib added a commit: rGb0b18b57a55b: sysctl vm.objects: report objects backing posix shm segments.

kib added a commit: rGa1258191d5e2: procstat vm: report posix shm segment mapping.

kib added a commit: rGba40b2b89962: vmstat -o: report objects backing posix shm segments.

Revision Contents
Changeset List

Path

Size

sys/

kern/

7 lines

vm/

5 lines

Diff 144474

sys/kern/kern_proc.c

Loading...

sys/vm/vm_object.c

Loading...