Differential D46883
bhyve: mark additional functions as __result_use_check Authored by khorben_defora.org on Oct 2 2024, 11:05 PM. Tags Referenced Files
Details This is a follow-up to ef9fc9609a1ff53047577aa7cf51246fc04c954b, teaching users of vm_map_gpa() and vm_rev_map_gpa() to check the results obtained. In turn, this applies to paddr_guest2host() and paddr_host2guest(). Sponsored by: The FreeBSD Foundation Build-tested in lib/libvmmapi and usr.sbin/bhyve; NFCI.
Diff Detail
Event TimelineComment Actions From a style perspective, the use of __result_use_check is inconsistent, in one file it appears at the end, in the other it appears right after the return type. I think some of the lines are also over 80 colums. I also don't really understand the change... the annotated functions return a value, not an error status. Were/are there callers that ignore the return value? |