If Intel firmware is already in operational mode at boot that takes
place at warm boot, BT adaptor can generate extra HCI events which
interferes with firmware mode detection logic. Ignore them.
Sponsored by: Future Crew LLC
MFC after: 1 month
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 59549 Build 56436: arc lint + arc unit
Event Timeline
| sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c | ||
|---|---|---|
| 577 | space after if; can do before commit; no need for a new revision here. | |
| 864 | see comment below | |
| 873 | Here and above you man do a partial usbd_copy_out but then skipping the remainder. Is that save or will that confuse some other logic in case of a failing condition + "goto"? Should you do all the conditional checks first and then do the usbd_copy_out() all together? | |
| sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c | ||
|---|---|---|
| 873 | I can't do any checks before data has been copied out of DMA-ble page cache. So I prefetch header to private on-stack memory to not thrash caller-supplied buffer on negative case, than do all the checks and than copy out all data to the buffer on success. | |