Page MenuHomeFreeBSD

ng_ubt_intel: Allow to attach to 9260 bluetooth adaptors
ClosedPublic

Authored by wulf on Sep 21 2024, 1:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 2:28 AM
Unknown Object (File)
Nov 9 2024, 8:47 AM
Unknown Object (File)
Nov 6 2024, 11:58 PM
Unknown Object (File)
Oct 30 2024, 7:44 AM
Unknown Object (File)
Oct 24 2024, 2:15 PM
Unknown Object (File)
Oct 22 2024, 1:57 PM
Unknown Object (File)
Oct 10 2024, 11:28 AM
Unknown Object (File)
Sep 28 2024, 6:06 PM

Details

Summary

with operational mode firmware.

Sponsored by: Future Crew LLC
MFC after: 1 month

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wulf requested review of this revision.Sep 21 2024, 1:57 PM
sys/netgraph/bluetooth/drivers/ubt/ng_ubt_intel.c
173

any reference (or potential #define) for these magic numbers? (0x1c, 0x03)?

Add #define for UBT_INTEL_TLV_IMAGE_TYPE

0x03 magic value is documented in comments

sys/netgraph/bluetooth/drivers/ubt/ng_ubt_intel.c
143

This is the same command as for 7260/8260 to get the version, just with different len/data? Did they change the interface for the 9260?

159

Is there any need to check evt->header.event == NG_HCI_EVENT_COMMAND_COMPL here too (as we do for 7260/8260)?

wulf added inline comments.
sys/netgraph/bluetooth/drivers/ubt/ng_ubt_intel.c
143

Yes, they did. 7260/8260 returns structure of fixed size, while 9260 returns list of key->value pairs.

159

That handled in D46736

This revision is now accepted and ready to land.Oct 28 2024, 2:28 AM
This revision was automatically updated to reflect the committed changes.
wulf marked 2 inline comments as done.