Paths

Table of Contentst

Differential D46734

ng_ubt_intel: Allow to attach to 9260 bluetooth adaptors
ClosedPublic
Actions

Authored by wulf on Sep 21 2024, 1:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 22, 4:56 AM

	Unknown Object (File)
	Nov 21 2024, 2:28 AM

	Unknown Object (File)
	Nov 9 2024, 8:47 AM

	Unknown Object (File)
	Nov 6 2024, 11:58 PM

	Unknown Object (File)
	Oct 30 2024, 7:44 AM

	Unknown Object (File)
	Oct 24 2024, 2:15 PM

	Unknown Object (File)
	Oct 22 2024, 1:57 PM

	Unknown Object (File)
	Oct 10 2024, 11:28 AM

View All 16 Files

Subscribers

shuriku_shurik.kiev.ua

Details

Reviewers

Commits

rG5ce844d3daa2: ng_ubt_intel: Allow to attach to 9260 bluetooth adaptors
rG19a577ea5cae: ng_ubt_intel: Allow to attach to 9260 bluetooth adaptors

Summary

with operational mode firmware.

Sponsored by: Future Crew LLC
MFC after: 1 month

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59547
Build 56434: arc lint + arc unit

Event Timeline

wulf created this revision.Sep 21 2024, 1:57 PM

Herald added subscribers: glebius, melifaro, donner, imp. · View Herald TranscriptSep 21 2024, 1:57 PM

wulf requested review of this revision.Sep 21 2024, 1:57 PM

Harbormaster completed remote builds in B59547: Diff 143566.Sep 21 2024, 1:57 PM

wulf mentioned this in D44861: Initial cut at Intel AX210 bluetooth support.Sep 21 2024, 2:11 PM

emaste added a subscriber: emaste.Sep 21 2024, 5:30 PM

emaste added inline comments.Sep 21 2024, 5:47 PM

sys/netgraph/bluetooth/drivers/ubt/ng_ubt_intel.c
171	any reference (or potential `#define`) for these magic numbers? (0x1c, 0x03)?

Add #define for UBT_INTEL_TLV_IMAGE_TYPE

0x03 magic value is documented in comments

Harbormaster completed remote builds in B59556: Diff 143587.Sep 21 2024, 10:12 PM

shuriku_shurik.kiev.ua added a subscriber: shuriku_shurik.kiev.ua.Sep 23 2024, 5:25 AM

bz added inline comments.Oct 17 2024, 11:36 AM

sys/netgraph/bluetooth/drivers/ubt/ng_ubt_intel.c
141	This is the same command as for 7260/8260 to get the version, just with different len/data? Did they change the interface for the 9260?
157	Is there any need to check evt->header.event == NG_HCI_EVENT_COMMAND_COMPL here too (as we do for 7260/8260)?

wulf marked 2 inline comments as done.Oct 27 2024, 11:37 AM

wulf added inline comments.

sys/netgraph/bluetooth/drivers/ubt/ng_ubt_intel.c
141	Yes, they did. 7260/8260 returns structure of fixed size, while 9260 returns list of key->value pairs.
157	That handled in D46736

bz accepted this revision.Oct 28 2024, 2:28 AM

This revision is now accepted and ready to land.Oct 28 2024, 2:28 AM

Closed by commit rG19a577ea5cae: ng_ubt_intel: Allow to attach to 9260 bluetooth adaptors (authored by wulf). · Explain WhyNov 6 2024, 11:32 PM

This revision was automatically updated to reflect the committed changes.

wulf marked 2 inline comments as done.

wulf added a commit: rG19a577ea5cae: ng_ubt_intel: Allow to attach to 9260 bluetooth adaptors.

wulf added a commit: rG5ce844d3daa2: ng_ubt_intel: Allow to attach to 9260 bluetooth adaptors.Sun, Dec 22, 3:39 AM

Revision Contents
Changeset List

Path

Size

sys/

netgraph/

bluetooth/

drivers/

ubt/

65 lines

Diff 143566

sys/netgraph/bluetooth/drivers/ubt/ng_ubt_intel.c

Loading...