Paths

Table of Contentst

Differential D46669

tcp: remove TCP_OFFLOAD_DISABLE
ClosedPublic
Actions

Authored by tuexen on Sep 13 2024, 8:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 12, 10:02 PM

	Unknown Object (File)
	Dec 2 2024, 1:07 AM

	Unknown Object (File)
	Nov 24 2024, 8:43 PM

	Unknown Object (File)
	Nov 12 2024, 1:39 AM

	Unknown Object (File)
	Nov 9 2024, 9:14 PM

	Unknown Object (File)
	Oct 27 2024, 5:42 PM

	Unknown Object (File)
	Oct 26 2024, 4:33 AM

	Unknown Object (File)
	Oct 15 2024, 8:22 PM

View All 33 Files

Subscribers

Details

Reviewers

np
rrs
rscheff
peter.lei_ieee.org
lstewart

Group Reviewers

Commits

rG1c6bb4c5789c: tcp: remove TCP_OFFLOAD_DISABLE

Summary

TCP_OFFLOAD_DISABLE is nowhere else used or defined. So remove it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Sep 13 2024, 8:47 PM

Herald added a reviewer: transport. · View Herald TranscriptSep 13 2024, 8:47 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Sep 13 2024, 8:47 PM

I'd be okay with removing the condition entirely. It is useful to have core data structures be a fixed size independent of configuration.

In D46669#1063601, @np wrote:

I'd be okay with removing the condition entirely. It is useful to have core data structures be a fixed size independent of configuration.

I'm not sure about the usefulness of having a fixed size. I'll bring that up on the fortnightly transport VC (agenda). The corresponding change would be a separate commit.

tuexen accepted this revision as: transport.Sep 16 2024, 10:52 AM

This revision is now accepted and ready to land.Sep 16 2024, 10:52 AM

Closed by commit rG1c6bb4c5789c: tcp: remove TCP_OFFLOAD_DISABLE (authored by tuexen). · Explain WhySep 16 2024, 10:57 AM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rG1c6bb4c5789c: tcp: remove TCP_OFFLOAD_DISABLE.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

2 lines

Diff 143381

sys/netinet/tcp_syncache.h

Loading...