Page MenuHomeFreeBSD

pf: Add a sysctl to limit work done for rdr source port rewriting
ClosedPublic

Authored by markj on Aug 30 2024, 5:30 PM.
Tags
None
Referenced Files
F103272726: D46495.diff
Fri, Nov 22, 10:11 PM
F103266166: D46495.id143193.diff
Fri, Nov 22, 8:17 PM
F103245925: D46495.id143193.diff
Fri, Nov 22, 2:26 PM
Unknown Object (File)
Tue, Nov 19, 5:31 AM
Unknown Object (File)
Sat, Nov 16, 12:56 AM
Unknown Object (File)
Mon, Nov 11, 12:54 AM
Unknown Object (File)
Fri, Nov 8, 4:06 PM
Unknown Object (File)
Wed, Nov 6, 11:27 AM

Details

Summary

It was pointed out that the current approach of exhaustively searching
for a free source port might be very time consuming. Limit the amount
of work that we might do before giving up.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Aug 30 2024, 5:30 PM

We should probably document this in pf(4).
And I should see about adding the others that are missing from that too.

This revision is now accepted and ready to land.Aug 30 2024, 7:58 PM

Mention the sysctl in pf.4 and pf.conf.5.

This revision now requires review to proceed.Sep 9 2024, 5:42 PM

I know I'm listed as a reviewer, but I can't assess the code change here. The gist of it looks good, though. I'd be a lot less worried about enabling the feature with this limiter in place.

It may want a man page date update.

This revision is now accepted and ready to land.Sep 9 2024, 5:55 PM