Differential D46446

vmm: Remove an unneeded lookup in devmem_create_cdev()
ClosedPublic
Actions

Authored by markj on Aug 27 2024, 12:04 AM.

Tags

None

Referenced Files

	F131800531: D46446.diff
	Sat, Oct 11, 6:44 AM

	Unknown Object (File)
	Wed, Oct 8, 5:43 PM

	Unknown Object (File)
	Wed, Oct 8, 4:24 PM

	Unknown Object (File)
	Tue, Oct 7, 3:24 AM

	Unknown Object (File)
	Tue, Sep 30, 5:19 PM

	Unknown Object (File)
	Mon, Sep 15, 9:55 PM

	Unknown Object (File)
	Sun, Sep 14, 12:39 AM

	Unknown Object (File)
	Sat, Sep 13, 8:57 PM

View All 81 Files

Subscribers

Details

Reviewers

corvink
jhb

Group Reviewers

Commits

rGf4002135a2be: vmm: Remove an unneeded lookup in devmem_create_cdev()

Summary

The sole caller of this function already holds a pointer to the VM's
softc, so rather than passing the VM name and looking it up again, just
pass the softc pointer directly. This function is only called from an
ioctl context, so the softc structure will remain live.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59190
Build 56077: arc lint + arc unit

Event Timeline

markj created this revision.Aug 27 2024, 12:04 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 27 2024, 12:04 AM

markj requested review of this revision.Aug 27 2024, 12:04 AM

markj added a parent revision: D46445: vmm: Factor most of sysctl_vmm_destroy() into a separate function.

markj added a child revision: D46447: vmm: Be more consistent with the credential used for VM lookup.

Harbormaster completed remote builds in B59190: Diff 142474.Aug 27 2024, 12:04 AM

corvink accepted this revision.Aug 28 2024, 6:42 AM

This revision is now accepted and ready to land.Aug 28 2024, 6:42 AM

jhb accepted this revision.Aug 28 2024, 4:41 PM

Closed by commit rGf4002135a2be: vmm: Remove an unneeded lookup in devmem_create_cdev() (authored by markj). · Explain WhyAug 28 2024, 7:13 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGf4002135a2be: vmm: Remove an unneeded lookup in devmem_create_cdev().

Revision Contents
Changeset List

Path

Size

sys/

dev/

vmm/

13 lines

Diff 142474

sys/dev/vmm/vmm_dev.c

Loading...