Page MenuHomeFreeBSD
Differential D46282

bhyve: Make boot ROM handling more consistent
ClosedPublic
Actions

Authored by markj on Aug 13 2024, 5:20 PM.
Tags
None
Referenced Files
F112242373: D46282.diff
Fri, Mar 14, 8:51 PM
F112227720: D46282.diff
Fri, Mar 14, 3:42 PM
F112222531: D46282.diff
Fri, Mar 14, 1:49 PM
Unknown Object (File)
Wed, Feb 26, 3:20 AM
Unknown Object (File)
Sat, Feb 22, 2:24 PM
Unknown Object (File)
Sat, Feb 22, 1:59 PM
Unknown Object (File)
Sat, Feb 22, 1:58 PM
Unknown Object (File)
Feb 8 2025, 12:12 AM
View All 40 Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
corvink
jrtc27
jhb
Group Reviewers
bhyve
Commits
rG43caa2e805c2: bhyve: Make boot ROM handling more consistent
Summary
  • On amd64, deprecate lpc.bootrom and lpc.bootvars. Use top-level config variables instead.
  • Introduce a generic predicate which can be used to determine whether the guest has a boot ROM.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Aug 13 2024, 5:20 PM
Herald added a reviewer: bhyve. · View Herald TranscriptAug 13 2024, 5:20 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
markj requested review of this revision.Aug 13 2024, 5:20 PM
Harbormaster completed remote builds in B59004: Diff 142048.Aug 13 2024, 5:20 PM
markj added a child revision: D45049: bhyve: Do not enable PCI BAR decoding if a boot ROM is present.Aug 13 2024, 5:20 PM
corvink accepted this revision.Aug 14 2024, 6:16 AM
This revision is now accepted and ready to land.Aug 14 2024, 6:16 AM
jhb accepted this revision.Aug 19 2024, 1:38 PM
jhb added inline comments.
usr.sbin/bhyve/bhyve_config.5
126

Is the detail about the memory location true on arm64?

markj marked an inline comment as done.Aug 19 2024, 1:49 PM
markj added inline comments.
usr.sbin/bhyve/bhyve_config.5
126

No, it's wrong on arm64. I'll reword it to something more generic.

Closed by commit rG43caa2e805c2: bhyve: Make boot ROM handling more consistent (authored by markj). · Explain WhyAug 19 2024, 1:59 PM
This revision was automatically updated to reflect the committed changes.
markj marked an inline comment as done.
markj added a commit: rG43caa2e805c2: bhyve: Make boot ROM handling more consistent.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
amd64/
20 lines
3 lines
3 lines
1 line
19 lines
24 lines
7 lines
3 lines
17 lines

Diff 142158

View Options

usr.sbin/bhyve/amd64/bhyverun_machdep.c

Loading...
View Options

usr.sbin/bhyve/amd64/ioapic.c

Loading...
View Options

usr.sbin/bhyve/amd64/pci_irq.c

Loading...
View Options

usr.sbin/bhyve/amd64/pci_lpc.h

Loading...
View Options

usr.sbin/bhyve/amd64/pci_lpc.c

Loading...
View Options

usr.sbin/bhyve/bhyve_config.5

Loading...
View Options

usr.sbin/bhyve/bhyverun.c

Loading...
View Options

usr.sbin/bhyve/bootrom.h

Loading...
View Options

usr.sbin/bhyve/bootrom.c

Loading...