if_pflog: Limit the maximum unit via new KPI
AcceptedPublic
Actions

Authored by zlei on Fri, Jun 28, 4:05 AM.

Details

Reviewers

Group Reviewers

network

Summary

The cloner has ability to limit maximum unit. Punish it to do that rather than roll our own.

No functional change intended.

MFC after: 1 week

Test Plan

Create up to PFLOGIFS_MAX ( 16 ) pflog interfaces, then it should fail to create additional interfaces.

# ifconfig pflog create
ifconfig: SIOCIFCREATE2 (pflog): No space left on device

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

zlei created this revision.Fri, Jun 28, 4:05 AM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptFri, Jun 28, 4:05 AM

This depends on D45757 which introduce the new flag IFC_F_LIMITUNIT .

zlei edited the summary of this revision. (Show Details)Fri, Jun 28, 4:29 AM

Punish it to do that rather

"Use it to do that" ?

I'm not going to argue about the pf code deserving punishment, but that might not be what you meant ;)

This revision is now accepted and ready to land.Fri, Jun 28, 7:35 AM

In D45767#1043866, @kp wrote:

Punish it to do that rather

"Use it to do that" ?

I'm not going to argue about the pf code deserving punishment, but that might not be what you meant ;)

Ah, yes. I'd refer pflog_clone_create() as clone create function, and V_pflog_cloner as the cloner ;)

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

if_pflog.c

9 lines

Diff 140330

View Options

if_pflog: Limit the maximum unit via new KPIAcceptedPublicActions