Page MenuHomeFreeBSD

linux64: Fix the build on arm64 with bti checking
ClosedPublic

Authored by andrew on Jun 3 2024, 4:21 PM.
Tags
None
Referenced Files
F169079461: D45468.id.diff
Mon, Aug 31, 8:49 AM
F169055102: D45468.id139364.diff
Mon, Aug 31, 6:48 AM
F168903790: D45468.id139500.diff
Sun, Aug 30, 4:45 PM
Unknown Object (File)
Sun, Aug 30, 2:28 AM
Unknown Object (File)
Wed, Aug 26, 8:18 PM
Unknown Object (File)
Wed, Aug 26, 5:30 PM
Unknown Object (File)
Wed, Aug 26, 5:10 PM
Unknown Object (File)
Tue, Aug 25, 3:25 PM
Subscribers

Details

Summary

When we enable checking for BTI on arm64 we need to include an ELF
not in all object files linked into a module.

As using objcopy from a binary to an ELF object file doesn't add the
note switch to using .incbin from an assembly file. This allows us to
add the needed note without affecting the included object.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew requested review of this revision.Jun 3 2024, 4:21 PM

Getting rid of ${OBJCOPY_TARGET} is a nice side effect

This revision is now accepted and ready to land.Jun 3 2024, 4:24 PM

I rather like this for some reason.

s/not/note/ in the commit message