vm_phys: use ilog2(x) instead of fls(x)-1
ClosedPublic
Actions

Authored by dougm on May 24 2024, 7:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jul 8, 8:13 PM

	Unknown Object (File)
	Tue, Jul 7, 8:34 AM

	Unknown Object (File)
	Mon, Jul 6, 5:30 AM

	Unknown Object (File)
	Sun, Jul 5, 5:48 AM

	Unknown Object (File)
	Fri, Jul 3, 10:59 PM

	Unknown Object (File)
	Fri, Jul 3, 6:29 AM

	Unknown Object (File)
	Thu, Jul 2, 2:44 PM

	Unknown Object (File)
	Jun 13 2026, 11:10 AM

View All 91 Files

Subscribers

imp

markj

Details

Reviewers

alc

Commits

rG543d55d79109: vm_phys: use ilog2(x) instead of fls(x)-1

Summary

One of these changes saves two instructions on an amd64 GENERIC-NODEBUG build. The rest are entirely cosmetic, because the compiler can deduce that x is nonzero, and avoid the needless test.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm requested review of this revision.May 24 2024, 7:33 AM

dougm created this revision.

Please coordinate this with @markj given his lazy init change.

This revision is now accepted and ready to land.Jun 4 2024, 5:01 PM

In D45331#1037497, @alc wrote:

Please coordinate this with @markj given his lazy init change.

Please go ahead. It'll be easy to rebase past this patch and I need to retest before pushing.

Closed by commit rG543d55d79109: vm_phys: use ilog2(x) instead of fls(x)-1 (authored by dougm). · Explain WhyJun 4 2024, 6:08 PM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rG543d55d79109: vm_phys: use ilog2(x) instead of fls(x)-1.

Herald added a subscriber: imp. · View Herald TranscriptJun 4 2024, 6:08 PM

Revision Contents
Changeset List

Path

Size

sys/

vm/

vm_phys.c

10 lines

Diff 139452

View Options

vm_phys: use ilog2(x) instead of fls(x)-1ClosedPublicActions