Page MenuHomeFreeBSD
Differential D45331

vm_phys: use ilog2(x) instead of fls(x)-1
ClosedPublic
Actions

Authored by dougm on Fri, May 24, 7:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 17, 12:08 AM
Unknown Object (File)
Sun, Jun 16, 6:06 PM
Unknown Object (File)
Tue, Jun 4, 6:21 PM
Unknown Object (File)
Tue, Jun 4, 6:05 PM
Unknown Object (File)
Mon, Jun 3, 12:00 PM
Unknown Object (File)
Sun, May 26, 6:01 PM
Subscribers
imp
markj

Details

Reviewers
alc
Commits
rG543d55d79109: vm_phys: use ilog2(x) instead of fls(x)-1
Summary

One of these changes saves two instructions on an amd64 GENERIC-NODEBUG build. The rest are entirely cosmetic, because the compiler can deduce that x is nonzero, and avoid the needless test.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Fri, May 24, 7:33 AM
dougm created this revision.
alc accepted this revision.Tue, Jun 4, 5:01 PM
alc added a subscriber: markj.

Please coordinate this with @markj given his lazy init change.

This revision is now accepted and ready to land.Tue, Jun 4, 5:01 PM
markj added a comment.Tue, Jun 4, 5:51 PM
In D45331#1037497, @alc wrote:

Please coordinate this with @markj given his lazy init change.

Please go ahead. It'll be easy to rebase past this patch and I need to retest before pushing.

Closed by commit rG543d55d79109: vm_phys: use ilog2(x) instead of fls(x)-1 (authored by dougm). · Explain WhyTue, Jun 4, 6:08 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rG543d55d79109: vm_phys: use ilog2(x) instead of fls(x)-1.
Herald added a subscriber: imp. · View Herald TranscriptTue, Jun 4, 6:08 PM

Revision Contents
Changeset List

PathSize
sys/
vm/
10 lines

Diff 139452

View Options

sys/vm/vm_phys.c

Loading...