vm_phys: use ilog2(x) instead of fls(x)-1
ClosedPublic
Actions

Authored by dougm on May 24 2024, 7:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jun 13, 11:10 AM

	Unknown Object (File)
	Sun, May 31, 1:24 AM

	Unknown Object (File)
	Sun, May 31, 1:20 AM

	Unknown Object (File)
	Tue, May 26, 11:01 PM

	Unknown Object (File)
	Tue, May 26, 11:00 PM

	Unknown Object (File)
	Mon, May 25, 2:38 AM

	Unknown Object (File)
	Mon, May 25, 2:29 AM

	Unknown Object (File)
	Apr 28 2026, 10:21 AM

View All 84 Files

Subscribers

imp

markj

Details

Reviewers

alc

Commits

rG543d55d79109: vm_phys: use ilog2(x) instead of fls(x)-1

Summary

One of these changes saves two instructions on an amd64 GENERIC-NODEBUG build. The rest are entirely cosmetic, because the compiler can deduce that x is nonzero, and avoid the needless test.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm requested review of this revision.May 24 2024, 7:33 AM

dougm created this revision.

Please coordinate this with @markj given his lazy init change.

This revision is now accepted and ready to land.Jun 4 2024, 5:01 PM

In D45331#1037497, @alc wrote:

Please coordinate this with @markj given his lazy init change.

Please go ahead. It'll be easy to rebase past this patch and I need to retest before pushing.

Closed by commit rG543d55d79109: vm_phys: use ilog2(x) instead of fls(x)-1 (authored by dougm). · Explain WhyJun 4 2024, 6:08 PM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rG543d55d79109: vm_phys: use ilog2(x) instead of fls(x)-1.

Herald added a subscriber: imp. · View Herald TranscriptJun 4 2024, 6:08 PM

Revision Contents
Changeset List

Path

Size

sys/

vm/

vm_phys.c

10 lines

Diff 139452

View Options

vm_phys: use ilog2(x) instead of fls(x)-1ClosedPublicActions