Page MenuHomeFreeBSD

busdma: better handling of small segment bouncing
ClosedPublic

Authored by mhorne on May 1 2024, 4:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 10, 4:12 AM
Unknown Object (File)
Wed, Jul 10, 4:11 AM
Unknown Object (File)
Wed, Jul 10, 4:11 AM
Unknown Object (File)
Sat, Jul 6, 10:42 AM
Unknown Object (File)
Jun 18 2024, 8:32 AM
Unknown Object (File)
Jun 13 2024, 6:29 PM
Unknown Object (File)
Jun 7 2024, 11:59 PM
Unknown Object (File)
May 27 2024, 2:14 AM

Details

Summary

Typically, when a DMA transaction requires bouncing, we will break up
the request into segments that are, at maximum, page-sized.

However, in the atypical case of a driver whose maximum segment size is
smaller than PAGE_SIZE, we end up inefficiently assigning each segment
its own bounce page. For example, the dwmmc driver has a maximum segment
size of 2048 (PAGE_SIZE / 2); a 4-page transfer ends up requiring 8
bounce pages in the current scheme.

We should attempt to batch segments into bounce pages more efficiently.
This is achieved by pushing all considerations of the maximum segment
size into the new _bus_dmamap_addsegs() function, which wraps
_bus_dmamap_addseg(). Thus we allocate the minimal number of bounce
pages required to complete the entire transfer, while still performing
the transfer with smaller-sized transactions.

For most drivers with a segment size >= PAGE_SIZE, this will have no
impact. For drivers like dwmmc mentioned above, this improves the memory
and performance efficiency when bouncing a large transfer.

Co-authored-by: jhb

Test Plan

Tinderbox.

Tested on the VisionFive v2 RISC-V SBC (dwmmc small segment case).

I am running this change on my amd64 workstation; no regressions so far. Will smoke test on arm64 as well.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable