linuxkpi: Add linuxkpi_video module
ClosedPublic
Actions

What is going to happen to sys/modules/linuxkpi_hdmi then? They both compile in linux_hdmi.c (okay, saw the other revision) We do not get symbol clashes?

Also if the two MIT-licensed files are obtained from Linux (or elsewhere) it would be good to mention it and from which OS/Version/Hash.

Otherwise I am really happy to see the linuxkpi_*.c file in common/src given I keep meaning to say that we should rename them all away from linux_?

In D44925#1025028, @bz wrote:

What is going to happen to sys/modules/linuxkpi_hdmi then? They both compile in linux_hdmi.c (okay, saw the other revision) We do not get symbol clashes?

It will die.

Currently only 5.15 uses linuxkpi_hdmi, 6.1 switched to linuxkpi_video.

Also if the two MIT-licensed files are obtained from Linux (or elsewhere) it would be good to mention it and from which OS/Version/Hash.

Otherwise I am really happy to see the linuxkpi_*.c file in common/src given I keep meaning to say that we should rename them all away from linux_?

I can do the rename.

Otherwise I am really happy to see the linuxkpi_*.c file in common/src given I keep meaning to say that we should rename them all away from linux_?

I can do the rename.

I'd suggest to pick a moment when people have little outstanding work at some point in the future; the trouble (as always) simply will be MFCing then... Let's take that separately.

bz accepted this revision.Fri, Apr 26, 5:17 AM

This revision is now accepted and ready to land.Fri, Apr 26, 5:17 AM

Closed by commit rG11d79c4756b7: linuxkpi: Add linuxkpi_video module (authored by manu). · Explain WhyTue, Apr 30, 5:59 AM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rG11d79c4756b7: linuxkpi: Add linuxkpi_video module.