Page MenuHomeFreeBSD
Differential D44723

ctl_backend_block: Add support for NVMe
ClosedPublic
Actions

Authored by jhb on Apr 9 2024, 11:04 PM.
Tags
None
Referenced Files
F83935804: D44723.diff
Fri, May 17, 1:37 AM
Unknown Object (File)
Sat, May 4, 6:38 PM
Unknown Object (File)
Sat, May 4, 2:22 AM
Unknown Object (File)
Sun, Apr 28, 10:24 AM
Unknown Object (File)
Fri, Apr 26, 4:59 AM
Unknown Object (File)
Thu, Apr 25, 7:30 PM
Unknown Object (File)
Apr 12 2024, 4:25 PM
Subscribers
None

Details

Reviewers
imp
ken
Group Reviewers
cam
Commits
rG374f12c52f1b: ctl_backend_block: Add support for NVMe
Summary

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57196
Build 54084: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 9 2024, 11:04 PM
Herald added a reviewer: cam. · View Herald TranscriptApr 9 2024, 11:04 PM
jhb requested review of this revision.Apr 9 2024, 11:04 PM
Harbormaster completed remote builds in B57014: Diff 136819.Apr 9 2024, 11:04 PM
jhb added a parent revision: D44722: ctl_backend_ramdisk: Add support for NVMe.Apr 9 2024, 11:04 PM
jhb added a child revision: D44724: ctl: Add NVMF port type and ioctls.
jhb added a reviewer: ken.Apr 9 2024, 11:11 PM
imp accepted this revision.Apr 13 2024, 8:34 PM

this again seems a mix of accesor changes and and real changes... likely not a problem, but the former is easier to review when segregated.

This revision is now accepted and ready to land.Apr 13 2024, 8:34 PM
jhb added a comment.Apr 16 2024, 7:25 PM

Hmm, I could split the ramdisk/block backends into one to use the accessors and generic error handlers and a second to add the NVME opcode handling.

jhb updated this revision to Diff 137335.Thu, Apr 18, 5:58 PM

Update after splitting into 2 commits

This revision now requires review to proceed.Thu, Apr 18, 5:58 PM
Harbormaster completed remote builds in B57196: Diff 137335.Thu, Apr 18, 5:58 PM
jhb added a parent revision: D44851: ctl_backend_block: Prepare for NVMe support.Thu, Apr 18, 5:58 PM
jhb removed a parent revision: D44722: ctl_backend_ramdisk: Add support for NVMe.
jhb updated this revision to Diff 137973.Wed, May 1, 8:30 PM

Update for CTL_IO_ASSERT macro

Harbormaster completed remote builds in B57509: Diff 137973.Wed, May 1, 8:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, May 3, 12:17 AM
Closed by commit rG374f12c52f1b: ctl_backend_block: Add support for NVMe (authored by jhb). · Explain Why
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG374f12c52f1b: ctl_backend_block: Add support for NVMe.

Revision Contents
Changeset List

PathSize
sys/
cam/
ctl/
477 lines

Diff 137335

View Options

sys/cam/ctl/ctl_backend_block.c

Loading...