Page MenuHomeFreeBSD
Differential D44341

arm64 gicv3: Use void pointers instead of vm_offset_t
ClosedPublic
Actions

Authored by jhb on Mar 13 2024, 6:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 27, 3:39 AM
Unknown Object (File)
Mon, Sep 23, 1:30 AM
Unknown Object (File)
Sun, Sep 22, 7:36 PM
Unknown Object (File)
Wed, Sep 18, 5:13 PM
Unknown Object (File)
Wed, Sep 18, 5:18 AM
Unknown Object (File)
Wed, Sep 18, 12:24 AM
Unknown Object (File)
Mon, Sep 16, 9:05 PM
Unknown Object (File)
Mon, Sep 16, 11:50 AM
View All 38 Files
Subscribers
emaste
imp

Details

Reviewers
andrew
manu
imp
Commits
rGeab7ae7811f6: arm64 gicv3: Use void pointers instead of vm_offset_t
Summary

This removes the need for local diffs in CheriBSD where vm_offset_t
is an address and not the same as a uintptr_t. No functional change.

Sponsored by: University of Cambridge, Google, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Mar 13 2024, 6:09 PM
Herald added a reviewer: andrew. · View Herald TranscriptMar 13 2024, 6:09 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: emaste, imp. · View Herald Transcript
jhb requested review of this revision.Mar 13 2024, 6:09 PM
Harbormaster completed remote builds in B56584: Diff 135702.Mar 13 2024, 6:09 PM
jhb added a child revision: D44342: arm64: Switch the address argument to cpu_*cache* to a pointer.Mar 13 2024, 6:10 PM
imp accepted this revision.Mar 13 2024, 7:59 PM
This revision is now accepted and ready to land.Mar 13 2024, 7:59 PM
andrew added inline comments.Mar 13 2024, 8:03 PM
sys/arm64/arm64/gicv3_its.c
708

Are these intended to be in this change?

jhb added inline comments.Mar 14 2024, 12:37 AM
sys/arm64/arm64/gicv3_its.c
708

I included them only for convenience. I can split out the cleanup fixes to a separate commit if that is better.

andrew accepted this revision.Mar 14 2024, 9:38 AM
andrew added inline comments.
sys/arm64/arm64/gicv3_its.c
723

If changing this you could also remove the extra newline, panic will print one for us.

Closed by commit rGeab7ae7811f6: arm64 gicv3: Use void pointers instead of vm_offset_t (authored by jhb). · Explain WhyMar 15 2024, 5:10 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGeab7ae7811f6: arm64 gicv3: Use void pointers instead of vm_offset_t.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
41 lines

Diff 135787

View Options

sys/arm64/arm64/gicv3_its.c

Loading...