Differential D44191

linux: require vnet(9) context in ifname_bsd_to_linux_name()
ClosedPublic
Actions

Authored by glebius on Mar 2 2024, 6:27 PM.

Tags

None

Referenced Files

	F137772816: D44191.id54425.diff
	Tue, Nov 25, 5:02 PM

	Unknown Object (File)
	Fri, Nov 21, 7:28 PM

	Unknown Object (File)
	Tue, Nov 11, 10:11 PM

	Unknown Object (File)
	Sat, Nov 1, 10:20 AM

	Unknown Object (File)
	Tue, Oct 28, 7:48 AM

	Unknown Object (File)
	Mon, Oct 27, 3:03 AM

	Unknown Object (File)
	Oct 25 2025, 1:54 AM

	Unknown Object (File)
	Oct 22 2025, 11:36 PM

Subscribers

Details

Reviewers

melifaro
dchagin

Commits

rGdb4429d00f0d: linux: require vnet(9) context in ifname_bsd_to_linux_name()
rGf45ecf5fe407: linux: require vnet(9) context in ifname_bsd_to_linux_name()
rG2f5a315b3074: linux: require vnet(9) context in ifname_bsd_to_linux_name()

Summary

This function is used by netlink(9) only. The netlink(9) taskqueue thread
runs in the vnet of the socket whose request the thread is processing
right now. This is a correct vnet and resetting it to vnet0 is incorrect.
If the function is to be used by any other caller in addition to
netlink(9), it would be caller's responsiblity to provide correct vnet(9).

PR: 277286

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56411
Build 53299: arc lint + arc unit

Event Timeline

glebius created this revision.Mar 2 2024, 6:27 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 2 2024, 6:27 PM

glebius requested review of this revision.Mar 2 2024, 6:27 PM

Harbormaster completed remote builds in B56411: Diff 135324.Mar 2 2024, 6:27 PM

melifaro accepted this revision.Mar 2 2024, 7:25 PM

This revision is now accepted and ready to land.Mar 2 2024, 7:25 PM

dchagin accepted this revision.Mar 2 2024, 10:39 PM

Closed by commit rG2f5a315b3074: linux: require vnet(9) context in ifname_bsd_to_linux_name() (authored by glebius). · Explain WhyMar 3 2024, 8:57 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG2f5a315b3074: linux: require vnet(9) context in ifname_bsd_to_linux_name().

glebius added a commit: rGf45ecf5fe407: linux: require vnet(9) context in ifname_bsd_to_linux_name().Mar 11 2024, 4:13 PM

glebius added a commit: rGdb4429d00f0d: linux: require vnet(9) context in ifname_bsd_to_linux_name().

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

4 lines

Diff 135324

sys/compat/linux/linux.c

Loading...