Page MenuHomeFreeBSD
Differential D43483

bhyve: Prepare to add arm64 support to the gdb stub
ClosedPublic
Actions

Authored by markj on Jan 17 2024, 11:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 7, 8:45 PM
Unknown Object (File)
Mon, Sep 7, 3:52 PM
Unknown Object (File)
Mon, Sep 7, 2:10 PM
Unknown Object (File)
Sun, Sep 6, 1:46 PM
Unknown Object (File)
Sun, Sep 6, 11:15 AM
Unknown Object (File)
Sun, Sep 6, 9:38 AM
Unknown Object (File)
Sun, Sep 6, 5:28 AM
Unknown Object (File)
Sun, Sep 6, 1:33 AM
View All Files
Subscribers
bcran
emaste
imp
rgrimes

Details

Reviewers
jhb
corvink
Group Reviewers
bhyve
Commits
rG596fe0bdc9f6: bhyve: Prepare to add arm64 support to the gdb stub
rG5f086566e02a: bhyve: Prepare to add arm64 support to the gdb stub
Summary

In particular:

  • Stop assuming that the breakpoint size is one byte.
  • Avoid referencing the "rip" field in machine-independent code, use a helper.

No functional change intended.

Sponsored by: Innovate UK

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Jan 17 2024, 11:21 PM
Herald added a reviewer: bhyve. · View Herald TranscriptJan 17 2024, 11:21 PM
Herald added subscribers: bcran, rgrimes, emaste, imp. · View Herald Transcript
markj requested review of this revision.Jan 17 2024, 11:21 PM
Harbormaster completed remote builds in B55470: Diff 132900.Jan 17 2024, 11:21 PM
corvink accepted this revision.Jan 18 2024, 8:23 AM
This revision is now accepted and ready to land.Jan 18 2024, 8:23 AM
jhb added inline comments.Jan 22 2024, 9:28 PM
usr.sbin/bhyve/gdb.c
1292–1293
1325
markj updated this revision to Diff 133179.Jan 22 2024, 11:55 PM
markj marked 2 inline comments as done.

Handle John's comments.

This revision now requires review to proceed.Jan 22 2024, 11:55 PM
Harbormaster completed remote builds in B55555: Diff 133179.Jan 22 2024, 11:55 PM
corvink accepted this revision.Jan 23 2024, 8:05 AM
This revision is now accepted and ready to land.Jan 23 2024, 8:05 AM
jhb accepted this revision.Jan 23 2024, 4:09 PM
Closed by commit rG5f086566e02a: bhyve: Prepare to add arm64 support to the gdb stub (authored by markj). · Explain WhyJan 23 2024, 4:46 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG5f086566e02a: bhyve: Prepare to add arm64 support to the gdb stub.
markj added a commit: rG596fe0bdc9f6: bhyve: Prepare to add arm64 support to the gdb stub.Jan 30 2024, 2:20 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
37 lines

Diff 133206

View Options

usr.sbin/bhyve/gdb.c

Loading...