Page MenuHomeFreeBSD

libpfctl: fix pfctl_do_ioctl()
ClosedPublic

Authored by kp on Oct 23 2023, 3:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 24, 11:52 PM
Unknown Object (File)
Wed, Jun 24, 6:19 PM
Unknown Object (File)
Wed, Jun 24, 3:33 PM
Unknown Object (File)
Tue, Jun 23, 8:59 AM
Unknown Object (File)
May 9 2026, 10:14 AM
Unknown Object (File)
May 8 2026, 7:00 AM
Unknown Object (File)
May 3 2026, 7:27 PM
Unknown Object (File)
Apr 28 2026, 1:40 PM
Subscribers

Details

Summary

pfctl_do_ioctl() copies the packed request data into the request buffer
and then frees it. However, it's possible for the buffer to be too small
for the reply, causing us to allocate a new buffer. We then copied from
the freed request, and freed it again.

Do not free the request buffer until we're all the way done.

PR: 274614
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable