Page MenuHomeFreeBSD

libpfctl: fix pfctl_do_ioctl()
ClosedPublic

Authored by kp on Oct 23 2023, 3:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 16, 4:35 AM
Unknown Object (File)
Tue, Oct 7, 1:22 PM
Unknown Object (File)
Thu, Sep 18, 4:28 AM
Unknown Object (File)
Sep 10 2025, 8:50 AM
Unknown Object (File)
Sep 7 2025, 5:40 AM
Unknown Object (File)
Sep 7 2025, 3:59 AM
Unknown Object (File)
Sep 6 2025, 11:12 PM
Unknown Object (File)
Sep 5 2025, 9:24 AM
Subscribers

Details

Summary

pfctl_do_ioctl() copies the packed request data into the request buffer
and then frees it. However, it's possible for the buffer to be too small
for the reply, causing us to allocate a new buffer. We then copied from
the freed request, and freed it again.

Do not free the request buffer until we're all the way done.

PR: 274614
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable