Page MenuHomeFreeBSD

libpfctl: fix pfctl_do_ioctl()
ClosedPublic

Authored by kp on Oct 23 2023, 3:13 PM.
Tags
None
Referenced Files
F140864317: D42329.diff
Mon, Dec 29, 12:21 AM
Unknown Object (File)
Wed, Dec 10, 2:38 AM
Unknown Object (File)
Wed, Dec 3, 7:07 AM
Unknown Object (File)
Nov 3 2025, 7:34 PM
Unknown Object (File)
Nov 3 2025, 7:32 PM
Unknown Object (File)
Nov 3 2025, 7:31 PM
Unknown Object (File)
Nov 3 2025, 7:29 PM
Unknown Object (File)
Oct 31 2025, 9:47 AM
Subscribers

Details

Summary

pfctl_do_ioctl() copies the packed request data into the request buffer
and then frees it. However, it's possible for the buffer to be too small
for the reply, causing us to allocate a new buffer. We then copied from
the freed request, and freed it again.

Do not free the request buffer until we're all the way done.

PR: 274614
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable