libpfctl: fix Coverity issues
ClosedPublic
Actions

Authored by kp on Oct 23 2023, 3:13 PM.

Details

Reviewers

Group Reviewers

network
pfsense

Commits

rGc2e7cbe0edb5: libpfctl: fix Coverity issues
rG275078f17251: libpfctl: fix Coverity issues
rG4abc3b482e0d: libpfctl: fix Coverity issues

Summary

handle snl_finalize_msg() returning NULL
insert the correct data into the states list
add missing nvlist_destroy()
incorrect order for array bounds

Coverity: 1522929, 1522925, 1522923, 1522921, 1522780, 1522770, 1522764, 1487785, 1471250
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Oct 23 2023, 3:13 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 23 2023, 3:13 PM

kp requested review of this revision.Oct 23 2023, 3:13 PM

kp added a parent revision: D42329: libpfctl: fix pfctl_do_ioctl().

Harbormaster completed remote builds in B54131: Diff 129248.Oct 23 2023, 3:13 PM

emaste accepted this revision.Oct 23 2023, 8:24 PM

emaste added inline comments.

lib/libpfctl/libpfctl.c
728	do we need `nvlist_destroy` in here too?
735	CID 1487785
1428	CID 1522764

This revision is now accepted and ready to land.Oct 23 2023, 8:24 PM

Closed by commit rG4abc3b482e0d: libpfctl: fix Coverity issues (authored by kp). · Explain WhyOct 24 2023, 9:35 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG4abc3b482e0d: libpfctl: fix Coverity issues.

kp added a commit: rG275078f17251: libpfctl: fix Coverity issues.Nov 1 2023, 9:06 AM

kp added a commit: rGc2e7cbe0edb5: libpfctl: fix Coverity issues.

Revision Contents
Changeset List

Path

Size

lib/

libpfctl/

libpfctl.c

14 lines

Diff 129284

View Options

libpfctl: fix Coverity issuesClosedPublicActions