HomeFreeBSD

libpfctl: fix Coverity issues

Description

libpfctl: fix Coverity issues

  • handle snl_finalize_msg() returning NULL
  • insert the correct data into the states list
  • add missing nvlist_destroy()
  • incorrect order for array bounds

Coverity: 1522929, 1522925, 1522923, 1522921, 1522780, 1522770, 1522764, 1487785, 1471250
Reviewed by: emaste
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D42330

(cherry picked from commit 4abc3b482e0d246cd3518622223795c8de102130)

Details

Provenance
kpAuthored on Oct 23 2023, 11:46 AM
Reviewer
emaste
Differential Revision
D42330: libpfctl: fix Coverity issues
Parents
rGa17aa2314d50: libpfctl: fix pfctl_do_ioctl()
Branches
Unknown
Tags
Unknown